Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 10533103: Disable tests for GetMimeTypeFromExtension (Closed)

Created:
8 years, 6 months ago by Wei James(wistoch)
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disable tests for GetMimeTypeFromExtension After enable GetMimeTypeFromExtension with JNI implementation, need to disable these tests firstly and can enable them after switch to APK test runner. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141752

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/android/gtest_filter/content_unittests_disabled View 1 chunk +4 lines, -0 lines 1 comment Download
M build/android/gtest_filter/net_unittests_disabled View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wei James(wistoch)
8 years, 6 months ago (2012-06-12 04:54:34 UTC) #1
nilesh
LGTM But you need a committer. Adding few people. http://codereview.chromium.org/10533103/diff/1/build/android/gtest_filter/content_unittests_disabled File build/android/gtest_filter/content_unittests_disabled (right): http://codereview.chromium.org/10533103/diff/1/build/android/gtest_filter/content_unittests_disabled#newcode47 build/android/gtest_filter/content_unittests_disabled:47: ...
8 years, 6 months ago (2012-06-12 05:05:30 UTC) #2
nilesh
Please mention the original CL in the description. (The CL which broke these tests.) On ...
8 years, 6 months ago (2012-06-12 05:07:28 UTC) #3
Wei James(wistoch)
On 2012/06/12 05:07:28, nileshagrawal1 wrote: > Please mention the original CL in the description. (The ...
8 years, 6 months ago (2012-06-12 05:10:06 UTC) #4
Yaron
lgtm
8 years, 6 months ago (2012-06-12 20:41:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10533103/1
8 years, 6 months ago (2012-06-12 20:41:15 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 21:54:05 UTC) #7
Change committed as 141752

Powered by Google App Engine
This is Rietveld 408576698