Issue 10533102: Allow the omnibox to recognize as URLs inputs that have a host component that ends with a hyphen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533102: Allow the omnibox to recognize as URLs inputs that have a host component that ends with a hyphen. (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Allow the omnibox to recognize as URLs inputs that have a host component that ends with a hyphen. BUG=123732 TEST=Type in "kline-.github.com/NAMS" in the address bar and check that the default action is to navigate. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141621

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_unittest.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/base/net_util.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/net_util.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

eroman: Sending your way since you so kindly OWNERS-r+ed the similar http://codereview.chromium.org/7222019

8 years, 6 months ago (2012-06-12 02:44:06 UTC) #1

lgtm

Expand Messages | Collapse Messages