Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10533098: mac: Improve framerate on accelerated pages in HiDPI mode. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

mac: Improve framerate on accelerated pages in HiDPI mode. RenderWidgetHost asked RWHV for a backing store in view coordinates, but RWHV matched in pixel coordinates. As a result, backing store allocation was considered unsuccessful repeatedly every frame, and every frame would retry until the frame timeout (50ms) was elapsed. If the browser process is very busy, the fps meter tends to show NaN fps: It renders FPS in the renderer, and since the renderer was almost always doing nothing (since it waited on the browser), almost all frame times were filtered out (very short frame times are filtered out), and often there were 0 frame times to sample from for FPS computation. BUG=132178 TEST=Open poster circle with FPS meter enabled. 60fps instead of NaN. TBR=avi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141675

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M content/browser/renderer_host/compositing_iosurface_mac.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 3 chunks +14 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
The way I compute the compositing IO surface view unit size is a bit hacky ...
8 years, 6 months ago (2012-06-12 01:24:23 UTC) #1
jbates
LGTM with nit https://chromiumcodereview.appspot.com/10533098/diff/1/content/browser/renderer_host/compositing_iosurface_mac.h File content/browser/renderer_host/compositing_iosurface_mac.h (right): https://chromiumcodereview.appspot.com/10533098/diff/1/content/browser/renderer_host/compositing_iosurface_mac.h#newcode57 content/browser/renderer_host/compositing_iosurface_mac.h:57: const gfx::Size& io_surface_size() const { return ...
8 years, 6 months ago (2012-06-12 17:11:13 UTC) #2
Nico
done, thanks. avi: OWNERS
8 years, 6 months ago (2012-06-12 17:18:11 UTC) #3
Avi (use Gerrit)
8 years, 6 months ago (2012-06-12 19:00:20 UTC) #4
owner rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698