Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 10533086: Action box menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Action box menu Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
index 67420301ede6bb849a4bf5f419684431f4ecd25b..6f5fcd3d3058a245d248d351a99eecd8504f555f 100644
--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
@@ -626,8 +626,9 @@ void BrowserActionsToolbarGtk::CreateAllButtons() {
extension_button_map_.clear();
int i = 0;
- for (extensions::ExtensionList::iterator iter = model_->begin();
- iter != model_->end(); ++iter) {
+ const extensions::ExtensionList& toolbar_items = model_->toolbar_items();
+ for (extensions::ExtensionList::const_iterator iter = toolbar_items.begin();
+ iter != toolbar_items.end(); ++iter) {
CreateButtonForExtension(*iter, i++);
}
}
@@ -797,7 +798,7 @@ bool BrowserActionsToolbarGtk::IsCommandIdChecked(int command_id) const {
}
bool BrowserActionsToolbarGtk::IsCommandIdEnabled(int command_id) const {
- const Extension* extension = model_->GetExtensionByIndex(command_id);
+ const Extension* extension = model_->toolbar_items()[command_id];
return extension->browser_action()->GetIsVisible(GetCurrentTabId());
}
@@ -808,7 +809,7 @@ bool BrowserActionsToolbarGtk::GetAcceleratorForCommandId(
}
void BrowserActionsToolbarGtk::ExecuteCommand(int command_id) {
- const Extension* extension = model_->GetExtensionByIndex(command_id);
+ const Extension* extension = model_->toolbar_items()[command_id];
GURL popup_url;
switch (model_->ExecuteBrowserAction(extension, browser(), &popup_url)) {
@@ -1039,7 +1040,7 @@ gboolean BrowserActionsToolbarGtk::OnOverflowButtonPress(
if (profile_->IsOffTheRecord())
model_index = model_->IncognitoIndexToOriginal(i);
- const Extension* extension = model_->GetExtensionByIndex(model_index);
+ const Extension* extension = model_->toolbar_items()[model_index];
BrowserActionButton* button = extension_button_map_[extension->id()].get();
overflow_menu_model_->AddItem(model_index, UTF8ToUTF16(extension->name()));
@@ -1079,7 +1080,7 @@ gboolean BrowserActionsToolbarGtk::OnOverflowMenuButtonPress(
if (profile_->IsOffTheRecord())
item_index = model_->IncognitoIndexToOriginal(item_index);
- const Extension* extension = model_->GetExtensionByIndex(item_index);
+ const Extension* extension = model_->toolbar_items()[item_index];
ExtensionButtonMap::iterator it = extension_button_map_.find(
extension->id());
if (it == extension_button_map_.end()) {
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/toolbar/action_box_menu_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698