Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 10533063: Use unique name for property deallocator. (Closed)

Created:
8 years, 6 months ago by oshima
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use unique name for property deallocator. Move type completeness check into functino. anonymous namespaces within the same namespace are treated as the same namespace. This is to avoid duplicated definitions. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141243

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ui/aura/window_property.h View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
8 years, 6 months ago (2012-06-08 15:50:13 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-08 17:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10533063/1002
8 years, 6 months ago (2012-06-08 17:19:17 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 18:22:58 UTC) #4
Change committed as 141243

Powered by Google App Engine
This is Rietveld 408576698