Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: webkit/media/android/webmediaplayer_manager_android.cc

Issue 10533049: Adding the logic for releasing decoder resources in WebMediaPlayerManagerAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressing feedbacks Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/media/android/webmediaplayer_manager_android.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/media/android/webmediaplayer_manager_android.h" 5 #include "webkit/media/android/webmediaplayer_manager_android.h"
6 6
7 #include "webkit/media/android/webmediaplayer_android.h" 7 #include "webkit/media/android/webmediaplayer_android.h"
8 8
9 // Threshold on the number of media players per renderer before we start
10 // attempting to release inactive media players.
11 static const int kMediaPlayerThreshold = 2;
12
9 namespace webkit_media { 13 namespace webkit_media {
10 14
11 WebMediaPlayerManagerAndroid::WebMediaPlayerManagerAndroid() 15 WebMediaPlayerManagerAndroid::WebMediaPlayerManagerAndroid()
12 : next_media_player_id_(0) { 16 : next_media_player_id_(0) {
13 } 17 }
14 18
15 WebMediaPlayerManagerAndroid::~WebMediaPlayerManagerAndroid() {} 19 WebMediaPlayerManagerAndroid::~WebMediaPlayerManagerAndroid() {
20 ReleaseMediaResources();
21 }
16 22
17 int WebMediaPlayerManagerAndroid::RegisterMediaPlayer( 23 int WebMediaPlayerManagerAndroid::RegisterMediaPlayer(
18 WebMediaPlayerAndroid* player) { 24 WebMediaPlayerAndroid* player) {
19 MediaPlayerInfo info; 25 media_players_[next_media_player_id_] = player;
20 info.player = player;
21 media_players_[next_media_player_id_] = info;
22 return next_media_player_id_++; 26 return next_media_player_id_++;
23 } 27 }
24 28
25 void WebMediaPlayerManagerAndroid::UnregisterMediaPlayer(int player_id) { 29 void WebMediaPlayerManagerAndroid::UnregisterMediaPlayer(int player_id) {
26 std::map<int32, MediaPlayerInfo>::iterator iter = 30 std::map<int32, WebMediaPlayerAndroid*>::iterator iter =
27 media_players_.find(player_id); 31 media_players_.find(player_id);
28 DCHECK(iter != media_players_.end()); 32 DCHECK(iter != media_players_.end());
29 33
30 media_players_.erase(player_id); 34 media_players_.erase(player_id);
31 } 35 }
32 36
37 void WebMediaPlayerManagerAndroid::RequestMediaResources(int player_id) {
38 std::map<int32, WebMediaPlayerAndroid*>::iterator iter =
39 media_players_.find(player_id);
40 DCHECK(iter != media_players_.end());
41
42 if ((iter->second)->IsInitialized())
43 return;
44
45 // Release active players that are paused. Because we only release paused
46 // players, the number of running players could go beyond the limit.
47 // TODO(qinmin): we should use LRU to release the oldest player if we are
48 // reaching hardware limit.
49 if (GetActivePlayerCount() < kMediaPlayerThreshold)
50 return;
51
52 std::map<int32, WebMediaPlayerAndroid*>::iterator player_it;
53 for (player_it = media_players_.begin();
54 player_it != media_players_.end(); ++player_it) {
55 WebMediaPlayerAndroid* player = player_it->second;
56 if (player->IsInitialized() && player->paused())
57 player->ReleaseMediaResources();
58 }
59 }
60
33 void WebMediaPlayerManagerAndroid::ReleaseMediaResources() { 61 void WebMediaPlayerManagerAndroid::ReleaseMediaResources() {
34 std::map<int32, MediaPlayerInfo>::iterator player_it; 62 std::map<int32, WebMediaPlayerAndroid*>::iterator player_it;
35 for (player_it = media_players_.begin(); 63 for (player_it = media_players_.begin();
36 player_it != media_players_.end(); ++player_it) { 64 player_it != media_players_.end(); ++player_it) {
37 (player_it->second).player->ReleaseMediaResources(); 65 (player_it->second)->ReleaseMediaResources();
38 } 66 }
39 } 67 }
40 68
69 int32 WebMediaPlayerManagerAndroid::GetActivePlayerCount() {
70 int32 count = 0;
71 std::map<int32, WebMediaPlayerAndroid*>::iterator iter;
72 for (iter = media_players_.begin(); iter != media_players_.end(); ++iter) {
73 if ((iter->second)->IsInitialized())
74 count++;
75 }
76 return count;
77 }
78
41 WebMediaPlayerAndroid* WebMediaPlayerManagerAndroid::GetMediaPlayer( 79 WebMediaPlayerAndroid* WebMediaPlayerManagerAndroid::GetMediaPlayer(
42 int player_id) { 80 int player_id) {
43 std::map<int32, MediaPlayerInfo>::iterator iter = 81 std::map<int32, WebMediaPlayerAndroid*>::iterator iter =
44 media_players_.find(player_id); 82 media_players_.find(player_id);
45 if (iter != media_players_.end()) 83 if (iter != media_players_.end())
46 return (iter->second).player; 84 return iter->second;
47 return NULL; 85 return NULL;
48 } 86 }
49 87
50 } // namespace webkit_media 88 } // namespace webkit_media
OLDNEW
« no previous file with comments | « webkit/media/android/webmediaplayer_manager_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698