Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10533046: TabContentsWrapper -> TabContents, part 4. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 4. Autocomplete. BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141137

Patch Set 1 #

Patch Set 2 : compiling is good #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -61 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/simple_web_view_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/simple_web_view_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 10 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/location_bar/click_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 8 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-07 19:07:48 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-07 20:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10533046/3002
8 years, 6 months ago (2012-06-07 20:06:07 UTC) #3
commit-bot: I haz the power
Try job failure for 10533046-3002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-07 21:39:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10533046/3002
8 years, 6 months ago (2012-06-07 22:17:54 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 00:56:20 UTC) #6
Change committed as 141137

Powered by Google App Engine
This is Rietveld 408576698