Remove chromeos::GDataFileSystem::GetOperationRegistry()

Remove chromeos::GDataFileSystem::GetOperationRegistry()

BUG=131505
TEST=unit_tests --gtest_filter="GData*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141182

[achuithb, 2012-06-07 09:55:39]

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right):

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:88: // Helper function
to get GDataSystemService from Profile.
Any reason why this is not in the anonymous namespace?

[hashimoto, 2012-06-07 10:11:57]

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right):

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:88: // Helper function
to get GDataSystemService from Profile.
On 2012/06/07 09:55:39, achuith.bhandarkar wrote:
> Any reason why this is not in the anonymous namespace?

Oops, done

[achuithb, 2012-06-07 10:24:43]

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right):

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:88: // Helper function
to get GDataSystemService from Profile.
On 2012/06/07 10:11:57, hashimoto wrote:
> On 2012/06/07 09:55:39, achuith.bhandarkar wrote:
> > Any reason why this is not in the anonymous namespace?
> 
> Oops, done

Is it possible to also move all the other functions (GetFileSystemOnUIThread,
CancelGDataDownloadOnUIThread) as well as GDataURLRequestJob class definition
and method definitions to anon namespace too? Should be a small change of moving
the end namespace marker.

[hashimoto, 2012-06-07 16:16:21]

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right):

http://codereview.chromium.org/10533042/diff/3001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:88: // Helper function
to get GDataSystemService from Profile.
On 2012/06/07 10:24:43, achuith.bhandarkar wrote:
> On 2012/06/07 10:11:57, hashimoto wrote:
> > On 2012/06/07 09:55:39, achuith.bhandarkar wrote:
> > > Any reason why this is not in the anonymous namespace?
> > 
> > Oops, done
> 
> Is it possible to also move all the other functions (GetFileSystemOnUIThread,
> CancelGDataDownloadOnUIThread) as well as GDataURLRequestJob class definition
> and method definitions to anon namespace too? Should be a small change of
moving
> the end namespace marker.

Done.

[satorux1, 2012-06-07 17:32:57]

LGTM

[achuithb, 2012-06-07 21:46:31]

On 2012/06/07 17:32:57, satorux1 wrote:
> LGTM

lgtm