Remove root window from screen_ash

Remove root window from screen_ash

BUG=123160
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141176

[sky, 2012-06-07 17:37:28]

http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h
File ash/root_window_controller.h (right):

http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
ash/root_window_controller.h:10: 
int: remove newline

http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
ash/root_window_controller.h:17: class Window;
nit: sort

http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
ash/root_window_controller.h:34: class RootWindowController {
Add a description.

http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
ash/root_window_controller.h:62: // background
DISALLOW_...

http://codereview.chromium.org/10533041/diff/5/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/10533041/diff/5/ash/shell.h#newcode63
ash/shell.h:63: //class DesktopBackgroundController;
remove commented out lines (numerous places here and in .cc).

http://codereview.chromium.org/10533041/diff/5/ash/wm/property_util.cc
File ash/wm/property_util.cc (right):

http://codereview.chromium.org/10533041/diff/5/ash/wm/property_util.cc#newcode81
ash/wm/property_util.cc:81: void SetRootWindowController(aura::Window* window,
internal::RootWindowController* controller) {
> 80

[oshima, 2012-06-07 18:03:40]

Ugh, looks like I uploaded work-in-progress to wrong CL (probably because I
patch this CL in to that). I removed patch set 2. Please
take a look at patch set 1.

- oshima

On 2012/06/07 17:37:28, sky wrote:
> http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h
> File ash/root_window_controller.h (right):
> 
>
http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
> ash/root_window_controller.h:10: 
> int: remove newline
> 
>
http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
> ash/root_window_controller.h:17: class Window;
> nit: sort
> 
>
http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
> ash/root_window_controller.h:34: class RootWindowController {
> Add a description.
> 
>
http://codereview.chromium.org/10533041/diff/5/ash/root_window_controller.h#n...
> ash/root_window_controller.h:62: // background
> DISALLOW_...
> 
> http://codereview.chromium.org/10533041/diff/5/ash/shell.h
> File ash/shell.h (right):
> 
> http://codereview.chromium.org/10533041/diff/5/ash/shell.h#newcode63
> ash/shell.h:63: //class DesktopBackgroundController;
> remove commented out lines (numerous places here and in .cc).
> 
> http://codereview.chromium.org/10533041/diff/5/ash/wm/property_util.cc
> File ash/wm/property_util.cc (right):
> 
>
http://codereview.chromium.org/10533041/diff/5/ash/wm/property_util.cc#newcode81
> ash/wm/property_util.cc:81: void SetRootWindowController(aura::Window* window,
> internal::RootWindowController* controller) {
> > 80

[sky, 2012-06-07 19:56:38]

LGTM

[commit-bot: I haz the power, 2012-06-07 20:10:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10533041/1

[commit-bot: I haz the power, 2012-06-07 21:34:59]

Try job failure for 10533041-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-08 02:56:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10533041/1

[commit-bot: I haz the power, 2012-06-08 05:37:07]

Change committed as 141176