Fix TAP_DOWN gesture event:

ui/base/gestures/gesture_sequence.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/gestures/gesture_sequence.h"
 
 #include <cmath>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 230 matching lines @@
 
   // NOTE: when modifying these state transitions, also update gestures.dot
   scoped_ptr<Gestures> gestures(new Gestures());
   GesturePoint& point = GesturePointForEvent(event);
   point.UpdateValues(event);
   RecreateBoundingBox();
   flags_ = event.GetEventFlags();
   const int point_id = points_[event.GetTouchId()].point_id();
   if (point_id < 0)
     return NULL;
+
+  // Send GESTURE_BEGIN for any touch pressed.
+  if (event.GetEventType() == ui::ET_TOUCH_PRESSED)
+    AppendBeginGestureEvent(point, gestures.get());
+
   switch (Signature(state_, point_id, event.GetEventType(), false)) {
     case GST_NO_GESTURE_FIRST_PRESSED:
       TouchDown(event, point, gestures.get());
       set_state(GS_PENDING_SYNTHETIC_CLICK);
       break;
     case GST_PENDING_SYNTHETIC_CLICK_FIRST_RELEASED:
       if (Click(event, point, gestures.get()))
         point.UpdateForTap();
       set_state(GS_NO_GESTURE);
       break;
@@ skipping 83 matching lines @@
         // Nothing else to do if we have more than 2 fingers active, since after
         // the release/cancel, there are still enough fingers to do pinch.
         // pinch_distance_current_ and pinch_distance_start_ will be updated
         // when the bounding-box is updated.
       }
       ResetVelocities();
       break;
     case GST_PINCH_THIRD_PRESSED:
     case GST_PINCH_FOURTH_PRESSED:
     case GST_PINCH_FIFTH_PRESSED:
-      AppendTapDownGestureEvent(point, gestures.get());
       pinch_distance_current_ = BoundingBoxDiagonal(bounding_box_);
       pinch_distance_start_ = pinch_distance_current_;
       break;
   }
 
   if (event.GetEventType() == ui::ET_TOUCH_RELEASED ||
       event.GetEventType() == ui::ET_TOUCH_CANCELLED)
-    AppendTapUpGestureEvent(point, gestures.get());
+    AppendEndGestureEvent(point, gestures.get());
 
   if (state_ != last_state)
     DVLOG(4) << "Gesture Sequence"
              << " State: " << state_
              << " touch id: " << event.GetTouchId();
 
   if (last_state == GS_PENDING_SYNTHETIC_CLICK && state_ != last_state)
     long_press_timer_->Stop();
 
   // The set of point_ids must be contiguous and include 0.
@@ skipping 96 matching lines @@
   return false;
 }
 
 void GestureSequence::AppendTapDownGestureEvent(const GesturePoint& point,
                                                 Gestures* gestures) {
   gestures->push_back(helper_->CreateGestureEvent(
       ui::ET_GESTURE_TAP_DOWN,
       point.first_touch_position(),
       flags_,
       base::Time::FromDoubleT(point.last_touch_time()),
       point_count_, 0.f, 1 << point.touch_id()));

[sadrul, 2012/06/06 19:51:14]

We don't need to send point_count_ here anymore. So let's remove it to make it 0
(just to make sure nothing is using/depending on this value being 1)

[varunjain, 2012/06/06 21:52:53]

Done.

 }
 
-void GestureSequence::AppendTapUpGestureEvent(const GesturePoint& point,
+void GestureSequence::AppendBeginGestureEvent(const GesturePoint& point,
                                               Gestures* gestures) {
   gestures->push_back(helper_->CreateGestureEvent(
-      ui::ET_GESTURE_TAP_UP,
+      ui::ET_GESTURE_BEGIN,
       point.first_touch_position(),
       flags_,
       base::Time::FromDoubleT(point.last_touch_time()),
+      point_count_, 0.f, 1 << point.touch_id()));
+}
+
+void GestureSequence::AppendEndGestureEvent(const GesturePoint& point,
+                                              Gestures* gestures) {
+  gestures->push_back(helper_->CreateGestureEvent(
+      ui::ET_GESTURE_END,
+      point.first_touch_position(),
+      flags_,
+      base::Time::FromDoubleT(point.last_touch_time()),
       point_count_, 0.f, 1 << point.touch_id()));
 }
 
 void GestureSequence::AppendClickGestureEvent(const GesturePoint& point,
                                               Gestures* gestures) {
   gfx::Rect er = point.enclosing_rectangle();
   gfx::Point center = er.CenterPoint();
   gestures->push_back(helper_->CreateGestureEvent(
       ui::ET_GESTURE_TAP,
       center,
@@ skipping 396 matching lines @@
     sign_y = 0;
   else
     sign_x = 0;
 
   AppendSwipeGesture(point, sign_x, sign_y, gestures);
 
   return true;
 }
 
 }  // namespace ui