Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: ui/aura/root_window_unittest.cc

Issue 10533029: Fix TAP_DOWN gesture event: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/aura/root_window.h" 5 #include "ui/aura/root_window.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/aura/client/event_client.h" 10 #include "ui/aura/client/event_client.h"
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 418
419 case ui::ET_GESTURE_SCROLL_UPDATE: 419 case ui::ET_GESTURE_SCROLL_UPDATE:
420 return "GESTURE_SCROLL_UPDATE"; 420 return "GESTURE_SCROLL_UPDATE";
421 421
422 case ui::ET_GESTURE_TAP: 422 case ui::ET_GESTURE_TAP:
423 return "GESTURE_TAP"; 423 return "GESTURE_TAP";
424 424
425 case ui::ET_GESTURE_TAP_DOWN: 425 case ui::ET_GESTURE_TAP_DOWN:
426 return "GESTURE_TAP_DOWN"; 426 return "GESTURE_TAP_DOWN";
427 427
428 case ui::ET_GESTURE_TAP_UP: 428 case ui::ET_GESTURE_BEGIN:
429 return "GESTURE_TAP_UP"; 429 return "GESTURE_BEGIN";
430
431 case ui::ET_GESTURE_END:
432 return "GESTURE_END";
430 433
431 case ui::ET_GESTURE_DOUBLE_TAP: 434 case ui::ET_GESTURE_DOUBLE_TAP:
432 return "GESTURE_DOUBLE_TAP"; 435 return "GESTURE_DOUBLE_TAP";
433 436
434 default: 437 default:
435 break; 438 break;
436 } 439 }
437 return ""; 440 return "";
438 } 441 }
439 442
(...skipping 23 matching lines...) Expand all
463 TouchEvent touch_pressed_event(ui::ET_TOUCH_PRESSED, gfx::Point(100, 101), 466 TouchEvent touch_pressed_event(ui::ET_TOUCH_PRESSED, gfx::Point(100, 101),
464 1, base::TimeDelta()); 467 1, base::TimeDelta());
465 int time_ms = 468 int time_ms =
466 static_cast<int>(ui::GestureConfiguration:: 469 static_cast<int>(ui::GestureConfiguration::
467 min_touch_down_duration_in_seconds_for_click() * 1000); 470 min_touch_down_duration_in_seconds_for_click() * 1000);
468 TouchEvent touch_released_event( 471 TouchEvent touch_released_event(
469 ui::ET_TOUCH_RELEASED, gfx::Point(100, 101), 1, 472 ui::ET_TOUCH_RELEASED, gfx::Point(100, 101), 1,
470 base::TimeDelta::FromMilliseconds(time_ms)); 473 base::TimeDelta::FromMilliseconds(time_ms));
471 root_window()->DispatchTouchEvent(&touch_pressed_event); 474 root_window()->DispatchTouchEvent(&touch_pressed_event);
472 root_window()->DispatchTouchEvent(&touch_released_event); 475 root_window()->DispatchTouchEvent(&touch_released_event);
473 EXPECT_EQ("TOUCH_PRESSED GESTURE_TAP_DOWN TOUCH_RELEASED GESTURE_TAP " 476 EXPECT_EQ("TOUCH_PRESSED GESTURE_BEGIN GESTURE_TAP_DOWN TOUCH_RELEASED "
474 "MOUSE_ENTERED MOUSE_MOVED MOUSE_PRESSED MOUSE_RELEASED " 477 "GESTURE_TAP MOUSE_ENTERED MOUSE_MOVED MOUSE_PRESSED "
475 "GESTURE_TAP_UP", 478 "MOUSE_RELEASED GESTURE_END",
476 EventTypesToString(filter->events())); 479 EventTypesToString(filter->events()));
477 filter->events().clear(); 480 filter->events().clear();
478 } 481 }
479 482
480 // ET_TOUCH_PRESSED should generate a GESTURE_TAP_DOWN. 483 // ET_TOUCH_PRESSED should generate a GESTURE_TAP_DOWN.
481 { 484 {
482 TouchEvent touch_event(ui::ET_TOUCH_PRESSED, gfx::Point(100, 101), 1, 485 TouchEvent touch_event(ui::ET_TOUCH_PRESSED, gfx::Point(100, 101), 1,
483 base::TimeDelta()); 486 base::TimeDelta());
484 root_window()->DispatchTouchEvent(&touch_event); 487 root_window()->DispatchTouchEvent(&touch_event);
485 EXPECT_EQ("TOUCH_PRESSED GESTURE_TAP_DOWN", 488 EXPECT_EQ("TOUCH_PRESSED GESTURE_BEGIN GESTURE_TAP_DOWN",
486 EventTypesToString(filter->events())); 489 EventTypesToString(filter->events()));
487 filter->events().clear(); 490 filter->events().clear();
488 } 491 }
489 492
490 // ET_TOUCH_MOVED should start a scroll and generate mouse drags (among other 493 // ET_TOUCH_MOVED should start a scroll and generate mouse drags (among other
491 // things). 494 // things).
492 { 495 {
493 TouchEvent touch_event(ui::ET_TOUCH_MOVED, gfx::Point(200, 201), 1, 496 TouchEvent touch_event(ui::ET_TOUCH_MOVED, gfx::Point(200, 201), 1,
494 base::TimeDelta()); 497 base::TimeDelta());
495 root_window()->DispatchTouchEvent(&touch_event); 498 root_window()->DispatchTouchEvent(&touch_event);
(...skipping 15 matching lines...) Expand all
511 EventTypesToString(filter->events())); 514 EventTypesToString(filter->events()));
512 filter->events().clear(); 515 filter->events().clear();
513 } 516 }
514 517
515 // ET_TOUCH_RELEASED should end the scroll and release the mouse. 518 // ET_TOUCH_RELEASED should end the scroll and release the mouse.
516 { 519 {
517 TouchEvent touch_event(ui::ET_TOUCH_RELEASED, gfx::Point(300, 201), 1, 520 TouchEvent touch_event(ui::ET_TOUCH_RELEASED, gfx::Point(300, 201), 1,
518 base::TimeDelta()); 521 base::TimeDelta());
519 root_window()->DispatchTouchEvent(&touch_event); 522 root_window()->DispatchTouchEvent(&touch_event);
520 EXPECT_EQ("TOUCH_RELEASED GESTURE_SCROLL_END MOUSE_DRAGGED MOUSE_RELEASED " 523 EXPECT_EQ("TOUCH_RELEASED GESTURE_SCROLL_END MOUSE_DRAGGED MOUSE_RELEASED "
521 "GESTURE_TAP_UP", 524 "GESTURE_END",
522 EventTypesToString(filter->events())); 525 EventTypesToString(filter->events()));
523 filter->events().clear(); 526 filter->events().clear();
524 } 527 }
525 } 528 }
526 529
527 TEST_F(RootWindowTest, MouseMoveThenTouch) { 530 TEST_F(RootWindowTest, MouseMoveThenTouch) {
528 EventFilterRecorder* filter = new EventFilterRecorder; 531 EventFilterRecorder* filter = new EventFilterRecorder;
529 root_window()->SetEventFilter(filter); // passes ownership 532 root_window()->SetEventFilter(filter); // passes ownership
530 533
531 test::TestWindowDelegate delegate; 534 test::TestWindowDelegate delegate;
(...skipping 17 matching lines...) Expand all
549 TouchEvent touch_pressed_event(ui::ET_TOUCH_PRESSED, gfx::Point(151, 151), 552 TouchEvent touch_pressed_event(ui::ET_TOUCH_PRESSED, gfx::Point(151, 151),
550 1, base::TimeDelta()); 553 1, base::TimeDelta());
551 int time_ms = 554 int time_ms =
552 static_cast<int>(ui::GestureConfiguration:: 555 static_cast<int>(ui::GestureConfiguration::
553 min_touch_down_duration_in_seconds_for_click() * 1000); 556 min_touch_down_duration_in_seconds_for_click() * 1000);
554 TouchEvent touch_released_event( 557 TouchEvent touch_released_event(
555 ui::ET_TOUCH_RELEASED, gfx::Point(151, 151), 1, 558 ui::ET_TOUCH_RELEASED, gfx::Point(151, 151), 1,
556 base::TimeDelta::FromMilliseconds(time_ms)); 559 base::TimeDelta::FromMilliseconds(time_ms));
557 root_window()->DispatchTouchEvent(&touch_pressed_event); 560 root_window()->DispatchTouchEvent(&touch_pressed_event);
558 root_window()->DispatchTouchEvent(&touch_released_event); 561 root_window()->DispatchTouchEvent(&touch_released_event);
559 EXPECT_EQ("TOUCH_PRESSED GESTURE_TAP_DOWN TOUCH_RELEASED GESTURE_TAP " 562 EXPECT_EQ("TOUCH_PRESSED GESTURE_BEGIN GESTURE_TAP_DOWN TOUCH_RELEASED "
560 "MOUSE_EXITED MOUSE_ENTERED MOUSE_MOVED MOUSE_PRESSED " 563 "GESTURE_TAP MOUSE_EXITED MOUSE_ENTERED MOUSE_MOVED "
561 "MOUSE_RELEASED GESTURE_TAP_UP", 564 "MOUSE_PRESSED MOUSE_RELEASED GESTURE_END",
562 EventTypesToString(filter->events())); 565 EventTypesToString(filter->events()));
563 filter->events().clear(); 566 filter->events().clear();
564 } 567 }
565 } 568 }
566 569
567 } // namespace aura 570 } // namespace aura
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698