Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10533007: Revert 138939 - alsa_output: Drain and pause pcm when stopping. (Closed)

Created:
8 years, 6 months ago by scherkus (not reviewing)
Modified:
8 years, 6 months ago
Reviewers:
dgreid
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 138939 - alsa_output: Drain and pause pcm when stopping. Call snd_pcm_drain when the output's Stop() function is called. This will keep some alsa interfaces from repeating the last samples played until Close() is called. This will also guarantee that all samples are played back if Close() is called immediately following Stop(). BUG=chromium-os:31211 TEST=Manual, play and pause youtube, both FLASH and HTML5 videos using the following alsa plugins as a sink for alsa_output: plug, hw, dmix, pulse, cras, jack. Observe that pauses are clean without repeated samples. Review URL: https://chromiumcodereview.appspot.com/10413075 TBR=dgreid@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M media/audio/linux/alsa_output.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M media/audio/linux/alsa_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/linux/alsa_wrapper.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
8 years, 6 months ago (2012-06-05 16:49:56 UTC) #1
scherkus (not reviewing)
8 years, 6 months ago (2012-06-05 16:50:21 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698