Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9339)

Unified Diff: chromeos/dbus/sms_client.cc

Issue 10533006: Support the ModemManager1 interfaces for SMS messages (Closed) Base URL: http://git.chromium.org/git/chromium/src@master
Patch Set: Only deliver messages after call to RequestUpdate Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/dbus/mock_modem_messaging_client.h ('K') | « chromeos/dbus/sms_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/sms_client.cc
diff --git a/chromeos/dbus/sms_client.cc b/chromeos/dbus/sms_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d923d8fd5e635fde6add0801349bd0b23e88883b
--- /dev/null
+++ b/chromeos/dbus/sms_client.cc
@@ -0,0 +1,130 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#include "chromeos/dbus/sms_client.h"
+
+#include <map>
+#include <utility>
+
+#include "base/bind.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "base/message_loop.h"
+#include "base/stringprintf.h"
+#include "base/stl_util.h"
+#include "base/values.h"
+#include "dbus/bus.h"
+#include "dbus/message.h"
+#include "dbus/object_proxy.h"
+#include "dbus/values_util.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+namespace {
+
+// SMSClient is used to communicate with the
+// org.freedesktop.ModemManager1.SMS service. All methods should be
+// called from the origin thread (UI thread) which initializes the
+// DBusThreadManager instance.
+class SMSClientImpl : public SMSClient {
+ public:
+ explicit SMSClientImpl(dbus::Bus* bus) : bus_(bus), weak_ptr_factory_(this) {}
+ virtual ~SMSClientImpl() {}
+
+ // Calls GetAll method. |callback| is called after the method call succeeds.
+ virtual void GetAll(const std::string& service_name,
+ const dbus::ObjectPath& object_path,
+ const GetAllCallback& callback) OVERRIDE {
+ dbus::ObjectProxy *proxy = bus_->GetObjectProxy(service_name, object_path);
+ dbus::MethodCall method_call(dbus::kDBusPropertiesInterface,
+ dbus::kDBusPropertiesGetAll);
+ dbus::MessageWriter writer(&method_call);
+ writer.AppendString(modemmanager::kModemManager1SmsInterface);
+ proxy->CallMethod(&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+ base::Bind(&SMSClientImpl::OnGetAll,
+ weak_ptr_factory_.GetWeakPtr(),
+ callback));
+ }
+
+ private:
+ // Handles responses of GetAll method calls.
+ void OnGetAll(const GetAllCallback& callback, dbus::Response* response) {
+ if (!response) {
+ // Must invoke the callback, even if there is no message.
+ callback.Run(base::DictionaryValue());
+ return;
+ }
+ dbus::MessageReader reader(response);
+ scoped_ptr<base::Value> value(dbus::PopDataAsValue(&reader));
+ base::DictionaryValue* dictionary_value = NULL;
+ if (!value.get() || !value->GetAsDictionary(&dictionary_value)) {
+ LOG(WARNING) << "Invalid response: " << response->ToString();
+ callback.Run(base::DictionaryValue());
+ return;
+ }
+ callback.Run(*dictionary_value);
+ }
+
+ dbus::Bus* bus_;
+ base::WeakPtrFactory<SMSClientImpl> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SMSClientImpl);
+};
+
+class SMSClientStubImpl : public SMSClient {
+ public:
+ SMSClientStubImpl() : weak_ptr_factory_(this) {}
+ virtual ~SMSClientStubImpl() {}
+
+ virtual void GetAll(const std::string& service_name,
+ const dbus::ObjectPath& object_path,
+ const GetAllCallback& callback) OVERRIDE {
+ // Ownership passed to callback
+ base::DictionaryValue *sms = new base::DictionaryValue();
+ sms->SetString("Number", "000-000-0000");
+ sms->SetString("Text",
+ "SMSClientStubImpl: Test Message: " + object_path.value());
+ sms->SetString("Timestamp", "Fri Jun 8 13:26:04 EDT 2012");
+
+ // Run callback asynchronously.
+ MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&SMSClientStubImpl::OnGetAll,
+ weak_ptr_factory_.GetWeakPtr(),
+ base::Owned(sms),
+ callback));
+ }
+
+ private:
+ void OnGetAll(base::DictionaryValue *sms,
+ const GetAllCallback& callback) {
+ callback.Run(*sms);
+ }
+
+ base::WeakPtrFactory<SMSClientStubImpl> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SMSClientStubImpl);
+};
+
+} // namespace
+
+////////////////////////////////////////////////////////////////////////////////
+// SMSClient
+
+SMSClient::SMSClient() {}
+
+SMSClient::~SMSClient() {}
+
+
+// static
+SMSClient* SMSClient::Create(DBusClientImplementationType type,
+ dbus::Bus* bus) {
+ if (type == REAL_DBUS_CLIENT_IMPLEMENTATION) {
+ return new SMSClientImpl(bus);
+ }
+ DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
+ return new SMSClientStubImpl();
+}
+
+} // namespace chromeos
« chromeos/dbus/mock_modem_messaging_client.h ('K') | « chromeos/dbus/sms_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698