Gesture Recognizer: Make short long press time configurable.

Gesture Recognizer: Make short long press time configurable.

BUG=133322
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143011

[sadrul, 2012-06-18 20:32:36]

LGTM

... but we are really calling it short-long-press? :/

[sky, 2012-06-18 20:42:52]

LGTM, with a better name too.

http://codereview.chromium.org/10532212/diff/1/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/10532212/diff/1/chrome/common/pref_names.h#new...
chrome/common/pref_names.h:710: extern const char
kShortLongPressTimeInSeconds[];
sort

[varunjain, 2012-06-19 05:05:55]

Also changed name to "semi_long_press_time" as suggested.

http://codereview.chromium.org/10532212/diff/1/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/10532212/diff/1/chrome/common/pref_names.h#new...
chrome/common/pref_names.h:710: extern const char
kShortLongPressTimeInSeconds[];
On 2012/06/18 20:42:52, sky wrote:
> sort

Done.

[commit-bot: I haz the power, 2012-06-19 05:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10532212/12001

[commit-bot: I haz the power, 2012-06-19 05:06:17]

Presubmit check for 10532212-12001 failed and returned exit status 1.

Traceback (most recent call last):
  File
"/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/checkerbase.py",
line 212, in CheckLines
    self._metadata_pass.Process(token)
  File
"/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/ecmametadatapass.py",
line 415, in Process
    self._ProcessToken()
  File
"/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/ecmametadatapass.py",
line 432, in _ProcessToken
    context = (self._ProcessContext() or self._context)
  File
"/b/commit-queue/workdir/chromium/third_party/closure_linter/closure_linter/ecmametadatapass.py",
line 369, in _ProcessContext
    while self._context.parent.type != EcmaContext.SWITCH:
AttributeError: 'NoneType' object has no attribute 'type'
Running presubmit commit checks ...
Internal error in
/b/commit-queue/workdir/chromium/chrome/browser/resources/gesture_config.js

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources

Presubmit checks took 1.3s to calculate.

[varunjain, 2012-06-19 05:14:32]

+arv for chrome/browser/resources/OWNERS

[arv (Not doing code reviews), 2012-06-19 17:42:00]

lgtm

[commit-bot: I haz the power, 2012-06-19 18:01:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10532212/12001

[commit-bot: I haz the power, 2012-06-19 19:16:25]

Change committed as 143011