src/objects.cc - Issue 10532198: Fix handling of numbers in SameValue method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 10532198: Fix handling of numbers in SameValue method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Drop obsolete condition completely. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 3b2db221f8e54e81282e7c4702ebde882b46d8cb..3466dcf18e58daba82ba1864085f8fc0bb3042f1 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -763,7 +763,6 @@ MaybeObject* Object::GetHash(CreationFlag flag) {

bool Object::SameValue(Object* other) {

if (other == this) return true;

- if (!IsHeapObject() || !other->IsHeapObject()) return false;

// The object is either a number, a string, an odd-ball,

// a real JS object, or a Harmony proxy.

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2186.js » ('j') | no next file with comments »