Rename back _linuxish to linux.

Rename back _linuxish to linux.

_linuxish is ambiguous. Use 'target_conditions' to include the required files
that are for linux on Android.

(TBR because the changes in chrome/browser/ui/gtk and content/app/android are all simple changes of #include file names)

BUG=none
TEST=Build successfully
TBR=erg@chromium.org,jrg@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144176

[jam, 2012-06-18 15:34:44]

http://codereview.chromium.org/10532178/diff/7001/chrome/app/breakpad_linux.h
File chrome/app/breakpad_linux.h (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/app/breakpad_linux.h...
chrome/app/breakpad_linux.h:5: #ifndef CHROME_APP_BREAKPAD_LINUXISH_H_
nit: update ifdef guards

http://codereview.chromium.org/10532178/diff/7001/chrome/browser/crash_handle...
File chrome/browser/crash_handler_host_linux.h (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/browser/crash_handle...
chrome/browser/crash_handler_host_linux.h:5: #ifndef
CHROME_BROWSER_CRASH_HANDLER_HOST_LINUXISH_H_
ditto

http://codereview.chromium.org/10532178/diff/7001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:5165: ['include',
'^browser/crash_handler_host_linux_stub\\.cc$'],
nit: do you really need regular expressions here (they slow down gyp a bit
afaik). i..e you can just add the .cc files. we only list the header files for
IDE's sake.

[Xianzhu, 2012-06-20 07:58:20]

Sorry for late response in vacation.

http://codereview.chromium.org/10532178/diff/7001/chrome/app/breakpad_linux.h
File chrome/app/breakpad_linux.h (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/app/breakpad_linux.h...
chrome/app/breakpad_linux.h:5: #ifndef CHROME_APP_BREAKPAD_LINUXISH_H_
On 2012/06/18 15:34:44, John Abd-El-Malek wrote:
> nit: update ifdef guards

Done.

http://codereview.chromium.org/10532178/diff/7001/chrome/browser/crash_handle...
File chrome/browser/crash_handler_host_linux.h (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/browser/crash_handle...
chrome/browser/crash_handler_host_linux.h:5: #ifndef
CHROME_BROWSER_CRASH_HANDLER_HOST_LINUXISH_H_
On 2012/06/18 15:34:44, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/10532178/diff/7001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/7001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:5165: ['include',
'^browser/crash_handler_host_linux_stub\\.cc$'],
Using 'sources/' is important here otherwise I must use a condition containing
the linux_breakpad variable but it is not available in 'target_conditions'
scope. I can copy the variable into the 'target_conditions' scope but that need
more tricky gyp lines.

I can simplify the regexes.

On 2012/06/18 15:34:44, John Abd-El-Malek wrote:
> nit: do you really need regular expressions here (they slow down gyp a bit
> afaik). i..e you can just add the .cc files. we only list the header files for
> IDE's sake.

[Xianzhu, 2012-06-20 08:02:17]

Sorry there is some problem with 'git cl upload'. I'll send email when the
upload succeeds.

[Xianzhu, 2012-06-21 05:46:26]

Just successfully uploaded, from Beijing office. Please review :)

[Mark Mentovai, 2012-06-21 14:49:38]

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5162: # We need 'target_conditions' to override
default filename_rules
Don’t use “we” in comments.

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5166: ['include', '^app/breakpad_linux.cc'],
Since you’re using regular expressions, use proper RE format:

Put a backslash before the dot.

Put a $ at the end of the pattern.

[Xianzhu, 2012-06-24 04:04:48]

Sorry for my slow response during vacation.

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5162: # We need 'target_conditions' to override
default filename_rules
On 2012/06/21 14:49:38, Mark Mentovai wrote:
> Don’t use “we” in comments.

Done.

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5166: ['include', '^app/breakpad_linux.cc'],
On 2012/06/21 14:49:38, Mark Mentovai wrote:
> Since you’re using regular expressions, use proper RE format:
> 
> Put a backslash before the dot.
> 
> Put a $ at the end of the pattern.

I used \\. and $ in the previous change set, but now I'm keeping consistent with
other regexps in this file (there is only one with \\. and $, while 245 others
without). Either one looks good to me.  I will be glad to add them if you still
think it's better to have them.

[Mark Mentovai, 2012-06-24 12:33:15]

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5166: ['include', '^app/breakpad_linux.cc'],
Xianzhu wrote:
> On 2012/06/21 14:49:38, Mark Mentovai wrote:
> > Since you’re using regular expressions, use proper RE format:
> > 
> > Put a backslash before the dot.
> > 
> > Put a $ at the end of the pattern.
> 
> I used \\. and $ in the previous change set, but now I'm keeping consistent
with
> other regexps in this file (there is only one with \\. and $, while 245 others
> without). Either one looks good to me.  I will be glad to add them if you
still
> think it's better to have them.

It is better to have them. That’s why I asked for them.

[Xianzhu, 2012-06-26 11:49:27]

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10532178/diff/14001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:5166: ['include', '^app/breakpad_linux.cc'],
Should we file a bug to add them elsewhere?

On 2012/06/24 12:33:15, Mark Mentovai wrote:
> Xianzhu wrote:
> > On 2012/06/21 14:49:38, Mark Mentovai wrote:
> > > Since you’re using regular expressions, use proper RE format:
> > > 
> > > Put a backslash before the dot.
> > > 
> > > Put a $ at the end of the pattern.
> > 
> > I used \\. and $ in the previous change set, but now I'm keeping consistent
> with
> > other regexps in this file (there is only one with \\. and $, while 245
others
> > without). Either one looks good to me.  I will be glad to add them if you
> still
> > think it's better to have them.
> 
> It is better to have them. That’s why I asked for them.

[Xianzhu, 2012-06-26 12:58:46]

Filed bug: http://crbug.com/134632 for \\. and $ in 'sources/' 'include' and
'exclude'.

Done in this CL.

[Mark Mentovai, 2012-06-26 13:56:08]

LGTM

[commit-bot: I haz the power, 2012-06-26 14:00:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10532178/28002

[commit-bot: I haz the power, 2012-06-26 14:00:45]

Presubmit check for 10532178-28002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/gtk
    content/app/android

Presubmit checks took 1.5s to calculate.

[commit-bot: I haz the power, 2012-06-26 14:04:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10532178/28002

[commit-bot: I haz the power, 2012-06-26 14:11:00]

Try job failure for 10532178-28002 (retry) on android for steps "build,
android_gyp".
It's a second try, previously, steps "build, android_gyp" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-06-26 14:12:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10532178/34002

[commit-bot: I haz the power, 2012-06-26 15:09:14]

Change committed as 144176