Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10532162: Rename IPC Sender and Listener in ppapi, content/public, and content/renderer (Closed)

Created:
8 years, 6 months ago by brettw
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename IPC Sender and Listener in ppapi, content/public, and content/renderer This is the new name in preparation for deleting the backwards-compatible typedef. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143282

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : new computer #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -122 lines) Patch
M chrome/browser/background/background_contents_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/simple_web_view_dialog.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/infobars/infobar_container.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/color_chooser_mac.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sad_tab_helper.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/prerender/prerenderer_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host.h View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host_helper.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/debugger/devtools_frontend_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_child_process_host_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 3 chunks +6 lines, -7 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_process_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/render_view_host_observer.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/utility_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 3 chunks +6 lines, -5 lines 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/child_process_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_thread.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/public/renderer/render_view.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M content/public/test/mock_render_thread.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/render_view_fake_resources_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/utility/utility_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/dom_automation_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/compositor_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/compositor_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/input_event_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/input_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/plugin_channel_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/plugin_channel_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_bindings.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/web_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/websharedworker_proxy.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_proxy.h View 3 chunks +5 lines, -6 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 3 chunks +8 lines, -7 lines 0 comments Download
M ppapi/proxy/plugin_proxy_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_device_id_proxy.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_x509_certificate_private_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppp_mouse_lock_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppp_printing_proxy.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppp_text_input_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Low priority. This is just a search-and-replace for some IPC stuff. I added OVERRIDE in ...
8 years, 6 months ago (2012-06-15 16:44:33 UTC) #1
Scott Hess - ex-Googler
LGTM. Once it compiles and stuff. https://chromiumcodereview.appspot.com/10532162/diff/1/content/renderer/render_thread_impl.h File content/renderer/render_thread_impl.h (right): https://chromiumcodereview.appspot.com/10532162/diff/1/content/renderer/render_thread_impl.h#newcode103 content/renderer/render_thread_impl.h:103: IPC::Listener* listener) OVERRIDE; ...
8 years, 6 months ago (2012-06-15 20:45:25 UTC) #2
brettw
TBR=ben for ui
8 years, 6 months ago (2012-06-20 22:25:21 UTC) #3
Ben Goodger (Google)
8 years, 6 months ago (2012-06-20 22:51:56 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698