Some cleanup of recompilation

lib/compiler/implementation/ssa/optimize.dart

Index: lib/compiler/implementation/ssa/optimize.dart
diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart
index ab0b54f1d689146ea7508cf6ebb1c50005375343..af319b4b597f770c952586141180811c68b5f503 100644
--- a/lib/compiler/implementation/ssa/optimize.dart
+++ b/lib/compiler/implementation/ssa/optimize.dart
@@ -589,12 +589,12 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {
     if (!isFinalOrConst &&
         !compiler.codegenWorld.hasInvokedSetter(field, compiler) &&
         !compiler.codegenWorld.hasFieldSetter(field, compiler)) {
-      switch (compiler.pass) {
-        case 1:
+      switch (compiler.phase) {
+        case Compiler.PHASE_COMPILING:
           compiler.enqueuer.codegen.registerRecompilationCandidate(
               work.element);

[ngeoffray, 2012/06/15 20:12:59]

I think putting such considerations into the new SSA phase you introduce in
another CL might be good.

Also, since you are unconditionally recompiling once a method is in the
recompliation queue, I think this phase should return a bool telling whether the
method is a candidate for recompilation. If it says true, then compilation is
aborted. This should save some time in total compile-time.

[Søren Gjesse, 2012/06/18 06:40:36]

I will move it to the new SSA phase when it is in through another CL.

Regarding aborting compilation, then I am not sure. Most of the information used
for feedback into the recompilation is currently collected in the code
generator, so if compilation is aborted then this information will not be
collected. Maybe we should move this gathering of information out of the codegen
and have a separate step for that. We can then skip the actual codegen for
recompilation candidates. Another option will be to have some predicates on the
recompilation candidates and check these before the actual recompilation. That
way we only recompile for profit.

           break;
-        case 2:
+        case Compiler.PHASE_RECOMPILING:
           // If field is not final or const but no setters are used then the
           // field might be considered final anyway as it will be either
           // un-initialized or initialized in the constructor initializer list.