Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2403)

Unified Diff: content/common/android/command_line.cc

Issue 10532155: Upstream some more content/ DEPS-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove JNIHelper/BitmapHolder Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/android/command_line.h ('k') | content/common/android/trace_event_binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/android/command_line.cc
diff --git a/content/browser/android/command_line.cc b/content/common/android/command_line.cc
similarity index 91%
rename from content/browser/android/command_line.cc
rename to content/common/android/command_line.cc
index 1883b07f0f973f10595ed99b1485b9ee93550def..5b951741d3ec0c903777b5bc6089a22df123a907 100644
--- a/content/browser/android/command_line.cc
+++ b/content/common/android/command_line.cc
@@ -2,14 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/android/command_line.h"
+#include "content/common/android/command_line.h"
+#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "jni/command_line_jni.h"
-#include "content/browser/android/jni_helper.h"
+using base::android::AppendJavaStringArrayToStringVector;
using base::android::ConvertJavaStringToUTF8;
namespace {
@@ -17,9 +18,9 @@ namespace {
void AppendJavaStringArrayToCommandLine(JNIEnv* env,
jobjectArray array,
bool includes_program) {
- CommandLine::StringVector vec;
+ std::vector<std::string> vec;
if (array)
- ConvertJavaArrayOfStringsToVectorOfStrings(env, array, &vec);
+ AppendJavaStringArrayToStringVector(env, array, &vec);
if (!includes_program)
vec.insert(vec.begin(), "");
CommandLine extra_command_line(vec);
« no previous file with comments | « content/common/android/command_line.h ('k') | content/common/android/trace_event_binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698