Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: content/common/android/command_line.cc

Issue 10532155: Upstream some more content/ DEPS-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove JNIHelper/BitmapHolder Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/common/android/command_line.h ('k') | content/common/android/trace_event_binding.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/android/command_line.h" 5 #include "content/common/android/command_line.h"
6 6
7 #include "base/android/jni_array.h"
7 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
8 #include "base/command_line.h" 9 #include "base/command_line.h"
9 #include "base/logging.h" 10 #include "base/logging.h"
10 #include "jni/command_line_jni.h" 11 #include "jni/command_line_jni.h"
11 #include "content/browser/android/jni_helper.h"
12 12
13 using base::android::AppendJavaStringArrayToStringVector;
13 using base::android::ConvertJavaStringToUTF8; 14 using base::android::ConvertJavaStringToUTF8;
14 15
15 namespace { 16 namespace {
16 17
17 void AppendJavaStringArrayToCommandLine(JNIEnv* env, 18 void AppendJavaStringArrayToCommandLine(JNIEnv* env,
18 jobjectArray array, 19 jobjectArray array,
19 bool includes_program) { 20 bool includes_program) {
20 CommandLine::StringVector vec; 21 std::vector<std::string> vec;
21 if (array) 22 if (array)
22 ConvertJavaArrayOfStringsToVectorOfStrings(env, array, &vec); 23 AppendJavaStringArrayToStringVector(env, array, &vec);
23 if (!includes_program) 24 if (!includes_program)
24 vec.insert(vec.begin(), ""); 25 vec.insert(vec.begin(), "");
25 CommandLine extra_command_line(vec); 26 CommandLine extra_command_line(vec);
26 CommandLine::ForCurrentProcess()->AppendArguments(extra_command_line, 27 CommandLine::ForCurrentProcess()->AppendArguments(extra_command_line,
27 includes_program); 28 includes_program);
28 } 29 }
29 30
30 } // namespace 31 } // namespace
31 32
32 static void Reset(JNIEnv* env, jclass clazz) { 33 static void Reset(JNIEnv* env, jclass clazz) {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 void InitNativeCommandLineFromJavaArray(JNIEnv* env, jobjectArray array) { 70 void InitNativeCommandLineFromJavaArray(JNIEnv* env, jobjectArray array) {
70 // TODO(port): Make an overload of Init() that takes StringVector rather than 71 // TODO(port): Make an overload of Init() that takes StringVector rather than
71 // have to round-trip via AppendArguments. 72 // have to round-trip via AppendArguments.
72 CommandLine::Init(0, NULL); 73 CommandLine::Init(0, NULL);
73 AppendJavaStringArrayToCommandLine(env, array, true); 74 AppendJavaStringArrayToCommandLine(env, array, true);
74 } 75 }
75 76
76 bool RegisterCommandLine(JNIEnv* env) { 77 bool RegisterCommandLine(JNIEnv* env) {
77 return RegisterNativesImpl(env); 78 return RegisterNativesImpl(env);
78 } 79 }
OLDNEW
« no previous file with comments | « content/common/android/command_line.h ('k') | content/common/android/trace_event_binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698