Adding java TouchPoint class for android

Adding java TouchPoint class for android

Upstream the java TouchPoint class before we upstream all the touch related stuff for chrome on android.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142835

[Yaron, 2012-06-14 20:13:06]

Why upstream this without its native counterpart and JNI binding? Does that have
too many dependencies on the rest of touch code?

[John Grabowski, 2012-06-14 20:49:10]

In general we're trying to upstream code that is somehow exercisable.  Yes, this
code will compile, but is it hit at any level?

[qinmin, 2012-06-14 21:25:38]

Ok, upstreamed the code for native side and JNI biding.

RegisterConstants() should get called when we register all the JNI environments.
However, BuildWebTouchEvent() will not be called by any function until we start
upstreaming the touch handling code in contentView.java.

[Yaron, 2012-06-14 21:56:27]

Deferring to jrg on whether to submit

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
File content/browser/android/touch_point.cc (right):

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
content/browser/android/touch_point.cc:16: void MaybeAddTouchPoint(JNIEnv* env,
jobject pt, WebKit::WebTouchEvent& event) {
Put in anon namespace

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
File content/browser/android/touch_point.h (right):

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
content/browser/android/touch_point.h:13: class TouchPoint {
New code should be content namespace

[qinmin, 2012-06-14 22:20:58]

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
File content/browser/android/touch_point.cc (right):

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
content/browser/android/touch_point.cc:16: void MaybeAddTouchPoint(JNIEnv* env,
jobject pt, WebKit::WebTouchEvent& event) {
On 2012/06/14 21:56:27, Yaron wrote:
> Put in anon namespace

Done.

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
File content/browser/android/touch_point.h (right):

http://codereview.chromium.org/10532148/diff/4001/content/browser/android/tou...
content/browser/android/touch_point.h:13: class TouchPoint {
On 2012/06/14 21:56:27, Yaron wrote:
> New code should be content namespace

Done.

[John Grabowski, 2012-06-14 23:48:10]

Brief questions.  After that I'm happy to have this land.  Thanks for hooking
this up!

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
File content/browser/android/touch_point.h (right):

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
content/browser/android/touch_point.h:9: #include <jni.h>
Quick question: will content shell ever use touch points and reference this file
explicitly?

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
content/browser/android/touch_point.h:15: class TouchPoint {
Class comment per style guide

[qinmin, 2012-06-15 00:14:02]

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
File content/browser/android/touch_point.h (right):

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
content/browser/android/touch_point.h:9: #include <jni.h>
According to Ted, the answer is yes.

On 2012/06/14 23:48:10, John Grabowski wrote:
> Quick question: will content shell ever use touch points and reference this
file
> explicitly?

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
content/browser/android/touch_point.h:15: class TouchPoint {
On 2012/06/14 23:48:10, John Grabowski wrote:
> Class comment per style guide

Done.

[qinmin, 2012-06-15 16:07:50]

add jam for content OWNER review

[jam, 2012-06-15 16:19:05]

On 2012/06/15 16:07:50, qinmin wrote:
> add jam for content OWNER review

lgtm (just looked at the gypi files, the rest jrg is an owner

[John Grabowski, 2012-06-18 18:37:29]

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
File content/browser/android/touch_point.h (right):

http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
content/browser/android/touch_point.h:9: #include <jni.h>
On 2012/06/15 00:14:02, qinmin wrote:
> According to Ted, the answer is yes.
> 
> On 2012/06/14 23:48:10, John Grabowski wrote:
> > Quick question: will content shell ever use touch points and reference this
> file
> > explicitly?
> 

If the answer is yes, this header needs to be in content/public.

[qinmin, 2012-06-18 18:40:22]

Sorry, some misunderstandings here. 
Content shell itself will not use touch point, it is just the page it brought up
will support touch.
So I think we should leave it here.
 
On 2012/06/18 18:37:29, John Grabowski wrote:
>
http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
> File content/browser/android/touch_point.h (right):
> 
>
http://codereview.chromium.org/10532148/diff/9001/content/browser/android/tou...
> content/browser/android/touch_point.h:9: #include <jni.h>
> On 2012/06/15 00:14:02, qinmin wrote:
> > According to Ted, the answer is yes.
> > 
> > On 2012/06/14 23:48:10, John Grabowski wrote:
> > > Quick question: will content shell ever use touch points and reference
this
> > file
> > > explicitly?
> > 
> 
> If the answer is yes, this header needs to be in content/public.

[John Grabowski, 2012-06-18 18:41:23]

LGTM

[commit-bot: I haz the power, 2012-06-18 18:53:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10532148/11001

[commit-bot: I haz the power, 2012-06-18 18:53:30]

Failed to apply patch for content/app/android/content_jni_registrar.cc:
While running patch -p1 --forward --force;
patching file content/app/android/content_jni_registrar.cc
Hunk #1 FAILED at 14.
Hunk #2 succeeded at 32 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file
content/app/android/content_jni_registrar.cc.rej

[commit-bot: I haz the power, 2012-06-18 20:04:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10532148/19001

[commit-bot: I haz the power, 2012-06-18 20:54:23]

Try job failure for 10532148-19001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-06-18 21:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10532148/19001

[commit-bot: I haz the power, 2012-06-18 22:32:44]

Change committed as 142835