Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10532147: Additional fixes for warning mismatch with scons. (Closed)

Created:
8 years, 6 months ago by noelallen1
Modified:
8 years, 6 months ago
Reviewers:
Derek Schuff
CC:
chromium-reviews
Visibility:
Public.

Description

Additional fixes for warning mismatch with scons. Fix broken SDK build due to mismatch in warning level which permits this conversions on the GYP build. TBR=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M ppapi/native_client/src/trusted/plugin/file_downloader.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_streaming_translate_thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Derek Schuff
8 years, 6 months ago (2012-06-14 22:20:02 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698