- Move the Timer interface to the dart:isolate library so that it

runtime/bin/builtin_natives.cc

Index: runtime/bin/builtin_natives.cc
===================================================================
--- runtime/bin/builtin_natives.cc	(revision 8601)
+++ runtime/bin/builtin_natives.cc	(working copy)
@@ -139,17 +139,16 @@
 }
 
 
-void Builtin::SetNativeResolver(Builtin::BuiltinLibraryId id) {
-  Dart_Handle url;
-  if (id == Builtin::kBuiltinLibrary) {
-    url = Dart_NewString(DartUtils::kBuiltinLibURL);
-  } else {
-    ASSERT(id == Builtin::kIOLibrary);
-    url = Dart_NewString(DartUtils::kIOLibURL);
-  }
-  Dart_Handle builtin_lib = Dart_LookupLibrary(url);
-  DART_CHECK_VALID(builtin_lib);
-  // Setup the native resolver for built in library functions.
-  Dart_Handle result = Dart_SetNativeResolver(builtin_lib, NativeLookup);
-  DART_CHECK_VALID(result);
+void Builtin::SetupIOLibrary(Dart_Handle io_lib) {

[siva, 2012/06/13 17:05:23]

The name SetupIOLibrary seems misleading as the function is not really setting
up the IO library.

How about SetupTimerImpl(....) ?

[Ivan Posva, 2012/06/21 16:17:06]

I imagine that we will have more than Timer being hooked eventually.

+  Dart_Handle url = Dart_NewString(DartUtils::kIsolateLibURL);
+  DART_CHECK_VALID(url);
+  Dart_Handle isolate_lib = Dart_LookupLibrary(url);
+  DART_CHECK_VALID(isolate_lib);
+  Dart_Handle timer_closure =
+      Dart_Invoke(io_lib, Dart_NewString("_getTimerFactoryClosure"), 0, NULL);
+  Dart_Handle args[1];
+  args[0] = timer_closure;
+  DART_CHECK_VALID(Dart_Invoke(isolate_lib,
+                               Dart_NewString("_setTimerFactoryClosure"),
+                               1, args));
 }