Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: net/url_request/url_request_throttler_entry.cc

Issue 10532121: NetLogEventParameter to Callback refactoring 6. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update includes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_throttler_entry.cc
===================================================================
--- net/url_request/url_request_throttler_entry.cc (revision 141814)
+++ net/url_request/url_request_throttler_entry.cc (working copy)
@@ -51,34 +51,18 @@
const char URLRequestThrottlerEntry::kExponentialThrottlingDisableValue[] =
"disable";
-// NetLog parameters when a request is rejected by throttling.
-class RejectedRequestParameters : public NetLog::EventParameters {
- public:
- RejectedRequestParameters(const std::string& url_id,
- int num_failures,
- int release_after_ms)
- : url_id_(url_id),
- num_failures_(num_failures),
- release_after_ms_(release_after_ms) {
- }
+// Returns NetLog parameters when a request is rejected by throttling.
+Value* NetLogRejectedRequestCallback(const std::string* url_id,
+ int num_failures,
+ int release_after_ms,
+ NetLog::LogLevel /* log_level */) {
+ DictionaryValue* dict = new DictionaryValue();
+ dict->SetString("url", *url_id);
+ dict->SetInteger("num_failures", num_failures);
+ dict->SetInteger("release_after_ms", release_after_ms);
+ return dict;
+}
- virtual Value* ToValue() const {
- DictionaryValue* dict = new DictionaryValue();
- dict->SetString("url", url_id_);
- dict->SetInteger("num_failures", num_failures_);
- dict->SetInteger("release_after_ms", release_after_ms_);
- return dict;
- }
-
- protected:
- virtual ~RejectedRequestParameters() {}
-
- private:
- std::string url_id_;
- int num_failures_;
- int release_after_ms_;
-};
-
URLRequestThrottlerEntry::URLRequestThrottlerEntry(
URLRequestThrottlerManager* manager,
const std::string& url_id)
@@ -178,10 +162,8 @@
net_log_.AddEvent(
NetLog::TYPE_THROTTLING_REJECTED_REQUEST,
- make_scoped_refptr(
- new RejectedRequestParameters(url_id_,
- num_failures,
- release_after_ms)));
+ base::Bind(&NetLogRejectedRequestCallback,
+ &url_id_, num_failures, release_after_ms));
reject_request = true;
}

Powered by Google App Engine
This is Rietveld 408576698