NetLogEventParameter to Callback refactoring 6.

NetLogEventParameter to Callback refactoring 6.
Get rid of all uses of NetLogEventParameters in net/url_request.

R=eroman@chromium.org
BUG=126243
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141981

[eroman, 2012-06-13 18:48:11]

lgtm

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
net/url_request/url_request.cc:427: NetLog::StringCallback("source", &source));
I wander if we want to introduce a:
   NetLog::CStringCallback(const char*, const char*);

Doesn't seem like this is a common pattern so no big deal either way.

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
net/url_request/url_request_http_job.cc:281: std::string source("delegate");
(Same comment as earlier applies here).

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
net/url_request/url_request_http_job.cc:479: std::string source("delegate");
Ditto.

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
net/url_request/url_request_http_job.cc:685: std::string source("delegate");
ditto.

[mmenke, 2012-06-13 19:32:09]

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/10532121/diff/4009/net/url_request/url_request...
net/url_request/url_request.cc:427: NetLog::StringCallback("source", &source));
On 2012/06/13 18:48:11, eroman wrote:
> I wander if we want to introduce a:
>    NetLog::CStringCallback(const char*, const char*);
> 
> Doesn't seem like this is a common pattern so no big deal either way.

I don't think we need it yet, though don't feel strongly about it.

[commit-bot: I haz the power, 2012-06-13 19:34:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10532121/4009

[commit-bot: I haz the power, 2012-06-13 20:01:26]

Try job failure for 10532121-4009 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-06-13 20:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10532121/4009

[commit-bot: I haz the power, 2012-06-13 22:03:44]

Change committed as 141981