Issue 10532110: Show old revision number in WebKit rolls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10532110: Show old revision number in WebKit rolls. (Closed)

Created:
8 years, 6 months ago by ojan

Modified:
8 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show old revision number in WebKit rolls. BUG=131920 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141798

Patch Set 2 : address nit #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	tools/safely-roll-webkit.py	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with optional nit, thanks! https://chromiumcodereview.appspot.com/10532110/diff/1/tools/safely-roll-webkit.py File tools/safely-roll-webkit.py (right): https://chromiumcodereview.appspot.com/10532110/diff/1/tools/safely-roll-webkit.py#newcode39 tools/safely-roll-webkit.py:39: old_rev = re.search(old_line, content) ...

8 years, 6 months ago (2012-06-12 22:01:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/10532110/5001

8 years, 6 months ago (2012-06-12 22:58:06 UTC) #3

Change committed as 141798

Expand Messages | Collapse Messages

Issue 10532110: Show old revision number in WebKit rolls. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address nit #

Messages