Use ICU script code "Jpan" instead of "Hrkt" in Japanese pref names

Use ICU script code "Jpan" instead of "Hrkt" in Japanese pref names.

The script code "Jpan" ("Japanese") is more suitable for naming font prefs for rendering Japanese than "Hrkt" ("Hiragana or Katakana").

With this change, the script code used in Chrome pref names for Japanese will become different than the one used in WebKit settings. We would have used "Jpan" in both Chrome and WebKit to begin with, but it is a newer script code that the version of ICU included in WebKit for MacOS doesn't have. But since Chrome now exposes script codes in the Font Settings Extension API, it's better to use the more appropriate, modern one. This patch just changes the script used internally by Chrome and translates it to the one used by WebKit when talking to WebCore.

BUG=2685
TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSetting*
TBR=pkasting,mpcomplete

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144418

[falken, 2012-06-12 15:24:53]

Tony: Can you please review? The only non-mechanical code change is under
webkit/.
Jungshik: FYI

[tony, 2012-06-12 18:15:31]

The code looks fine, but I defer to Jungshik's review.  webkit LGTM.

http://codereview.chromium.org/10532105/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/samples.json (left):

http://codereview.chromium.org/10532105/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/samples.json:2145: "ui_page_cycler.js"
Did you mean to remove ui_page_cycler.js?

[falken, 2012-06-12 23:49:37]

Tony: thanks for the review!
Jungshik: can you please review?

http://codereview.chromium.org/10532105/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/samples.json (left):

http://codereview.chromium.org/10532105/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/samples.json:2145: "ui_page_cycler.js"
On 2012/06/12 18:15:31, tony wrote:
> Did you mean to remove ui_page_cycler.js?

Yep, the unrelated changes under docs/ are automatic ones from running build.py.

[falken, 2012-06-14 10:28:18]

Jungshik: friendly ping

[jungshik at Google, 2012-06-14 21:42:17]

On 2012/06/14 10:28:18, falken wrote:
> Jungshik: friendly ping

Actually, 'hang' (for Hangul) had better be left alone. The issue of Hang vs
Kore is a bit different than Japn vs Hrkt (and others).

[jungshik at Google, 2012-06-14 21:49:47]

Sorry again for Kore vs Hang.  Could you revert that part of the CL?

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
chrome/browser/ui/prefs/prefs_tab_helper.cc:114: // "fonts.serif.Arab",
"fonts.serif.Kore", etc. are registered.
Leave alone 'Hang' and exclude 'Kore'.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
chrome/browser/ui/prefs/prefs_tab_helper.cc:239: return USCRIPT_KOREAN;
Perhaps, Kore -> Hang mapping makes more sense.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
File chrome/common/extensions/api/experimental_font_settings.json (right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
chrome/common/extensions/api/experimental_font_settings.json:33: "Jurc", "Kali",
"Khar", "Khmr", "Khoj", "Knda", "Kore", "Kpel", "Kthi",
same here. Keep Hang and exclude Kore. (sorry that I didn't make a distinction
between Japn vs Hrkt  and Kore vs Hang before).

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
File chrome/common/extensions/docs/static/experimental.fontSettings.html
(right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
chrome/common/extensions/docs/static/experimental.fontSettings.html:50: {
genericFamily: 'sansserif', script: 'Jpan', fontName: 'IPAPGothic' }
Perhaps, a more common Japanese font would be better as an example. 

'MS PGothic' 

It really doesn't matter, but just a though.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/pref_...
File chrome/common/pref_names.cc (right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/pref_...
chrome/common/pref_names.cc:254: const char kWebKitCursiveFontFamilyKorean[] =
In another CL, this should be auto-generated with a script when a lot more
preferences are added (for 20+ scripts * 3 ~ 5 generic CSS families).

[falken, 2012-06-15 03:58:11]

OK, I've reverted the Hang->Kore change.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
chrome/browser/ui/prefs/prefs_tab_helper.cc:114: // "fonts.serif.Arab",
"fonts.serif.Kore", etc. are registered.
On 2012/06/14 21:49:47, Jungshik Shin wrote:
> Leave alone 'Hang' and exclude 'Kore'. 

Done.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/browser/ui/p...
chrome/browser/ui/prefs/prefs_tab_helper.cc:239: return USCRIPT_KOREAN;
On 2012/06/14 21:49:47, Jungshik Shin wrote:
> Perhaps, Kore -> Hang mapping makes more sense. 

Done.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
File chrome/common/extensions/api/experimental_font_settings.json (right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
chrome/common/extensions/api/experimental_font_settings.json:33: "Jurc", "Kali",
"Khar", "Khmr", "Khoj", "Knda", "Kore", "Kpel", "Kthi",
On 2012/06/14 21:49:47, Jungshik Shin wrote:
> same here. Keep Hang and exclude Kore. (sorry that I didn't make a distinction
> between Japn vs Hrkt  and Kore vs Hang before). 

Done.

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
File chrome/common/extensions/docs/static/experimental.fontSettings.html
(right):

https://chromiumcodereview.appspot.com/10532105/diff/2020/chrome/common/exten...
chrome/common/extensions/docs/static/experimental.fontSettings.html:50: {
genericFamily: 'sansserif', script: 'Jpan', fontName: 'IPAPGothic' }
On 2012/06/14 21:49:47, Jungshik Shin wrote:
> Perhaps, a more common Japanese font would be better as an example. 
> 
> 'MS PGothic' 
> 
> It really doesn't matter, but just a though. 

Done.

[falken, 2012-06-20 05:16:55]

Jungshik: ping

[jungshik at Google, 2012-06-25 23:22:31]

LGTM 

Sorry I thought I lgtm'd this, but I didn't.

[falken, 2012-06-27 05:43:59]

Jungshik: Thanks

I plan to TBR the following OWNERS as it's a pretty mechanical change.

mpcomplete: extensions
pkasting: browser/ui

[commit-bot: I haz the power, 2012-06-27 05:47:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/10532105/17001

[commit-bot: I haz the power, 2012-06-27 05:47:20]

Presubmit check for 10532105-17001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/common/extensions/docs/examples/api/fontSettings/popup.js, line 27, 85
chars \
  chrome/common/extensions/docs/examples/api/fontSettings/popup.js, line 28, 85
chars

This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to
chrome/common/extensions/docs/static/experimental.fontSettings.html not
reflected in generated doc.
 - Changes to sample
chrome/common/extensions/docs/examples/api/fontSettings/popup.html have not been
re-zipped.
 - Changes to sample
chrome/common/extensions/docs/examples/api/fontSettings/popup.js have not been
re-zipped.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

[Matt Perry, 2012-06-27 17:39:49]

lgtm