Remove system tray specific code and arrow logic from SystemTrayBubbleView.

Remove system tray specific code and arrow logic from SystemTrayBubbleView.


BUG=124914
TEST=System trya bubble views and borders should look the same.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141273

[stevenjb, 2012-06-08 19:54:38]

Removing SystemTrayBubble dependencies from SystemTrayBubbleView in preparation
for moving SystemTrayBubbleView to its own file (to be used by the web
notification tray).

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_bubble.cc (left):

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.cc:50: const int kArrowPaddingFromBottom =
17;
These padding values are system tray specific and too large for smaller trays
(e.g. web notifications). I changed these to be smaller to keep the code
consistent for any tray, rather than adding an additional min offset parameter.

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.cc:51: const int kMinArrowOffset = 12;
kMinArrowOfsset was effectively shadowed by the padding values.

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.cc:258: const int arrow_offset_;
This was shadowing a member of BubbleBorder so I renamed it.

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.cc:401: + kArrowWidth / 2),
This is generally overridden by SystemTray and is the same as the min value so
is unnecessary.

[jennyz, 2012-06-08 20:20:17]

LGTM with a small nit.

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_bubble.h (right):

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.h:58: // Called wheever the bubble anchor
location may have moved.
typo: wheever->whenever

[sadrul, 2012-06-08 20:24:49]

LGTM

[stevenjb (google-dont-use), 2012-06-08 20:27:48]

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_bubble.h (right):

http://codereview.chromium.org/10532071/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.h:58: // Called wheever the bubble anchor
location may have moved.
On 2012/06/08 20:20:17, jennyz wrote:
> typo: wheever->whenever

Done.