Issue 10532063: Optimistically assume that elements IC only transition once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10532063: Optimistically assume that elements IC only transition once. (Closed)

Created:
8 years, 6 months ago by danno

Modified:
8 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Optimistically assume that elements IC only transition once. Thanks to Zheng Liu for identifying this issue. R=jkummerow@chromium.org BUG=v8:2141 TEST=test/mjsunit/elements-kind.js Committed: https://code.google.com/p/v8/source/detail?r=11739

Patch Set 1 #

Patch Set 2 : Add assertion #

Total comments: 1

Patch Set 3 : Review feedback #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -49 lines)			Patch
M	src/elements-kind.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+31 lines, -26 lines	0 comments	Download
M	src/objects.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+16 lines, -2 lines	0 comments	Download
M	src/objects-printer.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	test/mjsunit/elements-kind.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View	1 2	7 chunks	+29 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 6 months ago (2012-06-08 12:18:30 UTC) #2

LGTM

http://codereview.chromium.org/10532063/diff/13/test/mjsunit/elements-transit...
File test/mjsunit/elements-transition-hoisting.js (right):

http://codereview.chromium.org/10532063/diff/13/test/mjsunit/elements-transit...
test/mjsunit/elements-transition-hoisting.js:61: testDoubleConversion4(new
Array(5)); // Call twice to make sure that second
nit: Two spaces between ; and //, and a full stop at the end.
Consider putting the comment on its own line to save a line break.

More of the same below.

Expand Messages | Collapse Messages