Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 10532053: Detect output state at startup to avoid changes (Closed)

Created:
8 years, 6 months ago by disher
Modified:
8 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Detect output state at startup to avoid changes Resetting the state of the outputs causes a black flash on the screen so avoid doing this in the cases where the outputs were already configured such that they were in a state we can recognize. BUG=chromium:130943 TEST=Manually tested on lumpy with extra instrumentation to ensure that logging in as guest does not change the CRTCs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141209

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -2 lines) Patch
M chromeos/monitor/output_configurator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/monitor/output_configurator.cc View 1 3 chunks +107 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
LGTM https://chromiumcodereview.appspot.com/10532053/diff/1/chromeos/monitor/output_configurator.cc File chromeos/monitor/output_configurator.cc (right): https://chromiumcodereview.appspot.com/10532053/diff/1/chromeos/monitor/output_configurator.cc#newcode526 chromeos/monitor/output_configurator.cc:526: if (primary_mode == output_cache_[primary_output_index_].ideal_mode) { nit: remove curly ...
8 years, 6 months ago (2012-06-07 19:17:40 UTC) #1
Daniel Erat
Side comment: make sure you explicitly send mail about new issues on the code review ...
8 years, 6 months ago (2012-06-07 19:19:38 UTC) #2
disher
Thanks. I was going to ping you on IM once I had a moment. I ...
8 years, 6 months ago (2012-06-07 19:40:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/disher@chromium.org/10532053/2002
8 years, 6 months ago (2012-06-08 13:11:19 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 15:27:28 UTC) #5
Change committed as 141209

Powered by Google App Engine
This is Rietveld 408576698