Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5078)

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 10532037: Revert r139371 and r138961 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.cc
diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc
index 3fa1f32603757fedf8f61c2c4c1d984847345ece..338342da770e4a7fb7dd540e74d2bc292af44e4e 100644
--- a/chrome/common/extensions/extension_constants.cc
+++ b/chrome/common/extensions/extension_constants.cc
@@ -43,6 +43,8 @@ GURL GetWebstoreItemJsonDataURL(const std::string& extension_id) {
return GURL(GetWebstoreLaunchURL() + "/inlineinstall/detail/" + extension_id);
}
+const char kGalleryUpdateHttpUrl[] =
+ "http://clients2.google.com/service/update2/crx";
const char kGalleryUpdateHttpsUrl[] =
"https://clients2.google.com/service/update2/crx";
// TODO(battre): Delete the HTTP URL once the blacklist is downloaded via HTTPS.
@@ -51,22 +53,17 @@ const char kExtensionBlocklistUrlPrefix[] =
const char kExtensionBlocklistHttpsUrlPrefix[] =
"https://www.gstatic.com/chrome/extensions/blacklist";
-GURL GetWebstoreUpdateUrl() {
+GURL GetWebstoreUpdateUrl(bool secure) {
CommandLine* cmdline = CommandLine::ForCurrentProcess();
if (cmdline->HasSwitch(switches::kAppsGalleryUpdateURL))
return GURL(cmdline->GetSwitchValueASCII(switches::kAppsGalleryUpdateURL));
else
- return GURL(kGalleryUpdateHttpsUrl);
+ return GURL(secure ? kGalleryUpdateHttpsUrl : kGalleryUpdateHttpUrl);
}
bool IsWebstoreUpdateUrl(const GURL& update_url) {
- GURL store_url = GetWebstoreUpdateUrl();
- if (update_url == store_url) {
- return true;
- } else {
- return (update_url.host() == store_url.host() &&
- update_url.path() == store_url.path());
- }
+ return update_url == GetWebstoreUpdateUrl(false) ||
+ update_url == GetWebstoreUpdateUrl(true);
}
bool IsBlacklistUpdateUrl(const GURL& url) {
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698