Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: lib/dom/scripts/systeminterface.py

Issue 10532027: Move interface members traverse logic to BaseGenerator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/systeminterface.py
diff --git a/lib/dom/scripts/systeminterface.py b/lib/dom/scripts/systeminterface.py
index 162d44d93afb23708a760a29d847190464eae040..49d3a022adb59e0ce7aa6158a7afcee51f4a7e72 100644
--- a/lib/dom/scripts/systeminterface.py
+++ b/lib/dom/scripts/systeminterface.py
@@ -59,7 +59,7 @@ class InterfacesSystem(systembase.System):
# ------------------------------------------------------------------------------
-class DartInterfaceGenerator(object):
+class DartInterfaceGenerator(systembase.BaseGenerator):
"""Generates Dart Interface definition for one DOM IDL interface."""
def __init__(self, system, interface, emitter, template,
@@ -76,6 +76,7 @@ class DartInterfaceGenerator(object):
source_filter -- if specified, rewrites the names of any superinterfaces
that are not from these sources to use the common prefix.
"""
+ super(DartInterfaceGenerator, self).__init__(system._database)
self._system = system
self._interface = interface
self._emitter = emitter
@@ -199,13 +200,6 @@ class DartInterfaceGenerator(object):
raise Exception('Unexpected getter/setter combination %s %s' %
(getter, setter))
- def AddIndexer(self, element_type):
- # Interface inherits all operations from List<element_type>.
- pass
-
- def AmendIndexer(self, element_type):
- pass
-
def AddOperation(self, info):
"""
Arguments:
@@ -217,13 +211,3 @@ class DartInterfaceGenerator(object):
TYPE=info.type_name,
NAME=info.name,
PARAMS=info.ParametersInterfaceDeclaration())
-
- def AddStaticOperation(self, info):
- pass
-
- # Interfaces get secondary members directly via the superinterfaces.
- def AddSecondaryAttribute(self, interface, getter, setter):
- pass
-
- def AddSecondaryOperation(self, interface, attr):
- pass

Powered by Google App Engine
This is Rietveld 408576698