Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10532021: Keep track of which maps are associated with prototype objects so we can tune the fast-case vs. has… (Closed)

Created:
8 years, 6 months ago by Erik Corry
Modified:
8 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Keep track of which maps are associated with prototype objects so we can tune the fast-case vs. hash map heuristics accordingly. This is a reland of r11681 https://chromiumcodereview.appspot.com/10448011 , which was reverted because of layout test failures that were actually caused by the long-standing issue fixed in https://chromiumcodereview.appspot.com/10515006 (r11706). Committed: https://code.google.com/p/v8/source/detail?r=11727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -23 lines) Patch
M src/objects.h View 6 chunks +24 lines, -4 lines 0 comments Download
M src/objects.cc View 7 chunks +64 lines, -11 lines 0 comments Download
M src/objects-inl.h View 3 chunks +26 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +10 lines, -5 lines 0 comments Download
A test/mjsunit/fast-prototype.js View 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 6 months ago (2012-06-06 07:18:58 UTC) #1
Michael Starzinger
8 years, 6 months ago (2012-06-06 10:07:38 UTC) #2
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698