Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 10531002: Revert build/common.gypi modified in r140431. (Closed)

Created:
8 years, 6 months ago by Xianzhu
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Visibility:
Public.

Description

Revert build/common.gypi modified in r140431. The change caused issues when running make with goma because the envirnoment variable CXX_target etc. set in build/android/envsetup.sh are not full paths. Should check with yfriedman@ why full paths are needed for ninja. Revert build/common.gypi before the change. build/android/envsetup.sh of r140431 is good. Original review URL: https://chromiumcodereview.appspot.com/10511019/ TBR=jrg@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698