Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10528002: TabContentsWrapper -> TabContents, part 1. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, sadrul, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, jeremya+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, stuartmorgan+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, Ilya Sherman, kkania, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dyu1, jochen+watch-content_chromium.org, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, davemoore+watch_chromium.org, rdsmith+dwatch_chromium.org, James Su, mmenke
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 1. BUG=131026 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -697 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/test_autofill_external_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/simple_web_view_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_danger_prompt.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_actions_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/page_action_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/script_badge_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_unload_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/omnibox_search_hint.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_delegate_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_installer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/background_printing_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ssl_client_certificate_selector.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/drag_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/website_settings_popup_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/media_stream_infobar_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/snapshot_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/ui/tab_contents/tab_contents.h View 5 chunks +21 lines, -21 lines 0 comments Download
A + chrome/browser/ui/tab_contents/tab_contents.cc View 6 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 chunk +2 lines, -300 lines 0 comments Download
D chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 chunk +0 lines, -241 lines 0 comments Download
M chrome/browser/ui/tab_contents/test_tab_contents_wrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/stubs_aura.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/website_settings.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/web_dialogs/constrained_web_dialog_ui.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Yeah, I know. The problem is that if you typedef, the forward declarations don't match. ...
8 years, 6 months ago (2012-06-04 20:05:35 UTC) #1
jam
8 years, 6 months ago (2012-06-04 21:11:10 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698