Use default wallpaper when the logged in user didn't have saved wallpaper in LocalState

Fall back to use default wallpaper index when the logged in user didn't have index saved in LocalState.


BUG=130685
TEST=
1. Install R20 build
2. Add few new users
3. Verify that all new added users have default wallpaper set(Do not change wallpaper)
4. Autoupdate to R21 build
5. Check the existing users desktop wallpaper

Expected: default wallpaper should show up instead of a black wallpaper.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141224

[bshe, 2012-06-04 20:51:49]

Hi Nikita.

Could you please take a look at this CL? It fix a bug exist in
MigrationUserIndex function. See inline comments.

Thanks!

[Nikita (slow), 2012-06-05 08:07:17]

lgtm

http://codereview.chromium.org/10527006/diff/4001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_manager_impl.cc (left):

http://codereview.chromium.org/10527006/diff/4001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_manager_impl.cc:1030: if (user_wallpapers) {
Why this check is removed?
DCHECK(user_wallpapers)?

[bshe, 2012-06-08 15:22:52]

http://codereview.chromium.org/10527006/diff/4001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_manager_impl.cc (left):

http://codereview.chromium.org/10527006/diff/4001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_manager_impl.cc:1030: if (user_wallpapers) {
On 2012/06/05 08:07:17, Nikita Kostylev wrote:
> Why this check is removed?
> DCHECK(user_wallpapers)?

It seem this check is always true if we register the pref service. So I removed
it.

[commit-bot: I haz the power, 2012-06-08 15:23:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10527006/4001

[commit-bot: I haz the power, 2012-06-08 17:26:35]

Change committed as 141224