Autofill OSX: Draw red outline around incorrect CVC input.

Autofill OSX: Draw red outline around incorrect CVC input.

Change CVC text input field from NSTextField -> AutofillTextField,
and mark it as invalid (causing red border to be drawn) when a
retriable error occurs and no expiry date is showing. If an expiry date
is showing then it's not clear whether the date or CVC caused the error,
so don't mark either of them invalid.

BUG=448572
Committed: https://crrev.com/85992c2f23d449fda097f6f7dbcbb15678517c54
Cr-Commit-Position: refs/heads/master@{#323686}

[bondd, 2015-04-01 01:56:41]

Patchset #1 (id:1) has been deleted

[bondd, 2015-04-01 18:13:13]

bondd@chromium.org changed reviewers:
+ estade@chromium.org, groby@chromium.org

[bondd, 2015-04-01 18:13:13]

bondd@chromium.org changed required reviewers:
+ groby@chromium.org

[bondd, 2015-04-01 18:13:14]

https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:221:
[cvcInput_ setValidityMessage:@"invalid"];
AutofillTextField only checks this string for length == 0 so it can be anything.

[groby-ooo-7-16, 2015-04-02 22:32:56]

https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:221:
[cvcInput_ setValidityMessage:@"invalid"];
On 2015/04/01 18:13:14, bondd wrote:
> AutofillTextField only checks this string for length == 0 so it can be
anything.

I know :)

Check if this is used as a hover message, though.

[bondd, 2015-04-02 23:56:38]

On 2015/04/02 22:32:56, groby wrote:
>
https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
(right):
> 
>
https://codereview.chromium.org/1052513002/diff/20001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:221:
> [cvcInput_ setValidityMessage:@"invalid"];
> On 2015/04/01 18:13:14, bondd wrote:
> > AutofillTextField only checks this string for length == 0 so it can be
> anything.
> 
> I know :)
> 
> Check if this is used as a hover message, though.

Not used as a hover message.

[groby-ooo-7-16, 2015-04-03 00:34:35]

lgtm

[bondd, 2015-04-03 00:35:21]

The CQ bit was checked by bondd@chromium.org

[commit-bot: I haz the power, 2015-04-03 00:55:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052513002/20001

[commit-bot: I haz the power, 2015-04-03 08:01:23]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-04-03 20:35:13]

Patchset 1 (id:??) landed as
https://crrev.com/85992c2f23d449fda097f6f7dbcbb15678517c54
Cr-Commit-Position: refs/heads/master@{#323686}