Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: sync/engine/model_changing_syncer_command.h

Issue 10523003: Refactor following sync commit loop change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/commit.cc ('k') | sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/model_changing_syncer_command.h
diff --git a/sync/engine/model_changing_syncer_command.h b/sync/engine/model_changing_syncer_command.h
index e2e895619fb8a4f9235c1558741b895473ea9013..fba8d11fc9aaf8d7865d607283bdd6cdcfef0fd6 100644
--- a/sync/engine/model_changing_syncer_command.h
+++ b/sync/engine/model_changing_syncer_command.h
@@ -55,14 +55,6 @@ class ModelChangingSyncerCommand : public SyncerCommand {
virtual std::set<ModelSafeGroup> GetGroupsToChange(
const sessions::SyncSession& session) const = 0;
- // Sometimes, a command has work to do that needs to touch global state
- // belonging to multiple ModelSafeGroups, but in a way that is known to be
- // safe. This will be called once, prior to ModelChangingExecuteImpl,
- // *without* a ModelSafeGroup restriction in place on the SyncSession.
- // Returns true on success, false on failure.
- // TODO(tim): Remove this (bug 36594).
- virtual SyncerError ModelNeutralExecuteImpl(sessions::SyncSession* session);
-
// Abstract method to be implemented by subclasses to handle logic that
// operates on the model. This is invoked with a SyncSession ModelSafeGroup
// restriction in place so that bits of state belonging to data types
« no previous file with comments | « sync/engine/commit.cc ('k') | sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698