Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: sync/engine/build_commit_command.cc

Issue 10523003: Refactor following sync commit loop change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_ui_util.cc ('k') | sync/engine/commit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/build_commit_command.cc
diff --git a/sync/engine/build_commit_command.cc b/sync/engine/build_commit_command.cc
index f384c18dde9c0acdf8d170400c2c34b26ea1c34e..974cd3713d92becf44c0b931d107b6d1a1385b0d 100644
--- a/sync/engine/build_commit_command.cc
+++ b/sync/engine/build_commit_command.cc
@@ -124,11 +124,8 @@ SyncerError BuildCommitCommand::ExecuteImpl(SyncSession* session) {
static_cast<SyncEntity*>(commit_message->add_entries());
sync_entry->set_id(id);
MutableEntry meta_entry(session->write_transaction(),
- syncable::GET_BY_ID,
- id);
+ syncable::GET_BY_ID, id);
CHECK(meta_entry.good());
- // This is the only change we make to the entry in this function.
- meta_entry.Put(syncable::SYNCING, true);
DCHECK(0 != session->routing_info().count(meta_entry.GetModelType()))
<< "Committing change to datatype that's not actively enabled.";
« no previous file with comments | « chrome/browser/sync/sync_ui_util.cc ('k') | sync/engine/commit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698