Eliminate RawObject::class_ field entirely.

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/code_generator.h"
@@ skipping 655 matching lines @@
     // Store the type argument field.
     __ StoreIntoObject(EAX,
                        FieldAddress(EAX, Array::type_arguments_offset()),
                        ECX);
 
     // Set the length field.
     __ StoreIntoObject(EAX,
                        FieldAddress(EAX, Array::length_offset()),
                        EDX);
 
-    // EAX: new object start as a tagged pointer.
-    // EBX: new object end address.
-    // EDX: Array length as Smi.
-    // Store class value for array.
-    __ movl(ECX, FieldAddress(CTX, Context::isolate_offset()));
-    __ movl(ECX, Address(ECX, Isolate::object_store_offset()));
-    __ movl(ECX, Address(ECX, ObjectStore::array_class_offset()));
-    __ StoreIntoObject(EAX,
-                       FieldAddress(EAX, Array::class_offset()),
-                       ECX);
     // Calculate the size tag.
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // EDX: Array length as Smi.
     {
       Label size_tag_overflow, done;
       __ leal(ECX, Address(EDX, TIMES_2, fixed_size));  // EDX is Smi.
       ASSERT(kSmiTagShift == 1);
       __ andl(ECX, Immediate(-kObjectAlignment));
       __ cmpl(ECX, Immediate(RawObject::SizeTag::kMaxSizeTag));
@@ skipping 301 matching lines @@
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     // EAX: new object.
     // EBX: next object start.
     // EDX: number of context variables.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
 
-    // Initialize the class field in the context object.
-    // EAX: new object.
-    // EDX: number of context variables.
-    __ LoadObject(EBX, context_class);  // Load up class field of context.
-    __ StoreIntoObject(EAX,
-                       FieldAddress(EAX, Context::class_offset()),
-                       EBX);
     // Calculate the size tag.
     // EAX: new object.
     // EDX: number of context variables.
     {
       Label size_tag_overflow, done;
       __ leal(EBX, Address(EDX, TIMES_4, fixed_size));
       __ andl(EBX, Immediate(-kObjectAlignment));
       __ cmpl(EBX, Immediate(RawObject::SizeTag::kMaxSizeTag));
       __ j(ABOVE, &size_tag_overflow, Assembler::kNearJump);
       __ shll(EBX, Immediate(RawObject::kSizeTagBit - kObjectAlignmentLog2));
@@ skipping 138 matching lines @@
       // Initialize InstantiatedTypeArguments object at ECX.
       __ movl(Address(ECX,
           InstantiatedTypeArguments::uninstantiated_type_arguments_offset()),
               EDI);
       __ movl(EDX, Address(ESP, kInstantiatorTypeArgumentsOffset));
       __ movl(Address(ECX,
           InstantiatedTypeArguments::instantiator_type_arguments_offset()),
               EDX);
       const Class& ita_cls =
           Class::ZoneHandle(Object::instantiated_type_arguments_class());
-      __ LoadObject(EDX, ita_cls);
-      __ movl(Address(ECX, Instance::class_offset()), EDX);  // Set its class.
       // Set the tags.
       uword tags = 0;
       tags = RawObject::SizeTag::update(type_args_size, tags);
       tags = RawObject::ClassIdTag::update(ita_cls.id(), tags);
       __ movl(Address(ECX, Instance::tags_offset()), Immediate(tags));
       // Set the new InstantiatedTypeArguments object (ECX) as the type
       // arguments (EDI) of the new object (EAX).
       __ movl(EDI, ECX);
       __ addl(EDI, Immediate(kHeapObjectTag));
       // Set EBX to new object end.
       __ movl(EBX, ECX);
       __ Bind(&type_arguments_ready);
       // EAX: new object.
       // EDI: new object type arguments.
     }
 
-    // Initialize the class field in the object.
     // EAX: new object start.
     // EBX: next object start.
     // EDI: new object type arguments (if is_cls_parameterized).
     __ LoadObject(EDX, cls);  // Load class of object to be allocated.
-    __ movl(Address(EAX, Instance::class_offset()), EDX);
     // Set the tags.
     uword tags = 0;
     tags = RawObject::SizeTag::update(instance_size, tags);
     ASSERT(cls.id() != kIllegalObjectKind);
     tags = RawObject::ClassIdTag::update(cls.id(), tags);
     __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags));
 
     // Initialize the remaining words of the object.
     const Immediate raw_null =
         Immediate(reinterpret_cast<intptr_t>(Object::null()));
@@ skipping 127 matching lines @@
     if (FLAG_use_slow_path) {
       __ jmp(&slow_case);
     } else {
       __ j(ABOVE_EQUAL, &slow_case, Assembler::kNearJump);
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
 
-    // Initialize the class field in the object.
     // EAX: new closure object.
     // ECX: new context object (only if is_implicit_closure).
-    __ LoadObject(EDX, cls);  // Load signature class of closure.
-    __ movl(Address(EAX, Closure::class_offset()), EDX);
     // Set the tags.
     uword tags = 0;
     tags = RawObject::SizeTag::update(closure_size, tags);
     tags = RawObject::ClassIdTag::update(cls.id(), tags);
     __ movl(Address(EAX, Closure::tags_offset()), Immediate(tags));
 
     // Initialize the function field in the object.
     // EAX: new closure object.
     // ECX: new context object (only if is_implicit_closure).
     // EBX: next object start.
     __ LoadObject(EDX, func);  // Load function of closure to be allocated.
     __ movl(Address(EAX, Closure::function_offset()), EDX);
 
     // Setup the context for this closure.
     if (is_implicit_static_closure) {
       ObjectStore* object_store = Isolate::Current()->object_store();
       ASSERT(object_store != NULL);
       const Context& empty_context =
           Context::ZoneHandle(object_store->empty_context());
       __ LoadObject(EDX, empty_context);
       __ movl(Address(EAX, Closure::context_offset()), EDX);
     } else if (is_implicit_instance_closure) {
       // Initialize the new context capturing the receiver.
-
-      // Set the class field to the Context class.
       const Class& context_class = Class::ZoneHandle(Object::context_class());
-      __ LoadObject(EBX, context_class);
-      __ movl(Address(ECX, Context::class_offset()), EBX);
       // Set the tags.
       uword tags = 0;
       tags = RawObject::SizeTag::update(context_size, tags);
       tags = RawObject::ClassIdTag::update(context_class.id(), tags);
       __ movl(Address(ECX, Context::tags_offset()), Immediate(tags));
 
       // Set number of variables field to 1 (for captured receiver).
       __ movl(Address(ECX, Context::num_variables_offset()), Immediate(1));
 
       // Set isolate field to isolate of current context.
@@ skipping 496 matching lines @@
 // TOS + 2: instance.
 // TOS + 3: cache array.
 // Result in ECX: null -> not found, otherwise result (true or false).
 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
   GenerateSubtypeNTestCacheStub(assembler, 3);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32