Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10521003: Eliminate standalone timeout_test, pass_test, and fail_test. (Closed)

Created:
8 years, 6 months ago by Bill Hesse
Modified:
8 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate standalone timeout_test, pass_test, and fail_test. These are now built into standalone/io/test_runner_test. BUG=dart:3216 TEST=tools/test.py standalone/io/test_runner_test Committed: https://code.google.com/p/dart/source/detail?r=8315

Patch Set 1 #

Patch Set 2 : Remove timeout_test, pass_test, fail_test. #

Total comments: 2

Patch Set 3 : Change a forgotten string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -56 lines) Patch
D tests/standalone/fail_test.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 2 2 chunks +34 lines, -17 lines 0 comments Download
D tests/standalone/pass_test.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
M tests/standalone/standalone.status View 1 3 chunks +0 lines, -5 lines 0 comments Download
M tests/standalone/timeout_test.dart View 1 1 chunk +0 lines, -11 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
https://chromiumcodereview.appspot.com/10521003/diff/2001/tests/standalone/io/test_runner_test.dart File tests/standalone/io/test_runner_test.dart (right): https://chromiumcodereview.appspot.com/10521003/diff/2001/tests/standalone/io/test_runner_test.dart#newcode69 tests/standalone/io/test_runner_test.dart:69: Expect.throws(new RunningProcess(MakeTestCase("pass_test", [SKIP])).start); Change "pass_test" to "pass". Not really ...
8 years, 6 months ago (2012-06-04 12:35:07 UTC) #1
srdjan
I do not understand testing framework nor python to be able to review this code.
8 years, 6 months ago (2012-06-04 23:51:55 UTC) #2
srdjan
On 2012/06/04 23:51:55, srdjan wrote: > I do not understand testing framework nor python to ...
8 years, 6 months ago (2012-06-04 23:59:44 UTC) #3
Bill Hesse
http://codereview.chromium.org/10521003/diff/2001/tests/standalone/io/test_runner_test.dart File tests/standalone/io/test_runner_test.dart (right): http://codereview.chromium.org/10521003/diff/2001/tests/standalone/io/test_runner_test.dart#newcode69 tests/standalone/io/test_runner_test.dart:69: Expect.throws(new RunningProcess(MakeTestCase("pass_test", [SKIP])).start); On 2012/06/04 12:35:07, Bill Hesse wrote: ...
8 years, 6 months ago (2012-06-06 08:06:34 UTC) #4
Anders Johnsen
8 years, 6 months ago (2012-06-06 09:02:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698