Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10520003: Use short-hand update syntax for simple updating definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address more comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/optimize.dart
diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart
index 1a69ff7167bc060db25384d73a97d34737e8eef6..9ea146f623e1625bacb3b3a058778351c50cc5e3 100644
--- a/lib/compiler/implementation/ssa/optimize.dart
+++ b/lib/compiler/implementation/ssa/optimize.dart
@@ -1000,10 +1000,10 @@ class SsaCodeMotion extends HBaseVisitor implements OptimizationPhase {
void visitBasicBlock(HBasicBlock block) {
List<HBasicBlock> successors = block.successors;
- // Phase 1: get the ValueSet of all successors, compute the
- // intersection and move the instructions of the intersection into
- // this block.
- if (successors.length != 0) {
+ // Phase 1: get the ValueSet of all successors (if there are more than one),
+ // compute the intersection and move the instructions of the intersection
+ // into this block.
+ if (successors.length > 1) {
ValueSet instructions = values[successors[0].id];
for (int i = 1; i < successors.length; i++) {
ValueSet other = values[successors[i].id];
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698