Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10519010: Disable off-store extension install on non-Aura. (Closed)

Created:
8 years, 6 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Disable off-store extension install on non-Aura. In order to install extensions and user scripts, users will now need to download them and drag them onto chrome://extensions. Theme install works as before. BUG=55584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140527

Patch Set 1 #

Patch Set 2 : whoopsi #

Patch Set 3 : argh, more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -37 lines) Patch
M chrome/browser/download/download_crx_util.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 chunks +33 lines, -28 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_switch_utils.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Aaron Boodman
8 years, 6 months ago (2012-06-04 16:59:46 UTC) #1
Aaron Boodman
There's still a few more patches I need to land, but I think this is ...
8 years, 6 months ago (2012-06-04 17:01:01 UTC) #2
Yoyo Zhou
8 years, 6 months ago (2012-06-04 17:06:44 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698