chrome/browser/ui/views/location_bar/location_icon_view.cc - Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge to LKGR Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_icon_view.h ('k') | chrome/browser/ui/views/location_bar/page_action_with_badge_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc

index 6109c2072a2dd3991883f27f3ebf624145631a38..dc2d4f8baa9194f5093fec038e1ca6fac2e7b793 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc

@@ -11,6 +11,7 @@

LocationIconView::LocationIconView(LocationBarView* location_bar)

: ALLOW_THIS_IN_INITIALIZER_LIST(page_info_helper_(this, location_bar)) {

SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON));

+ TouchableLocationBarView::Init(this);

}

LocationIconView::~LocationIconView() {

@@ -35,6 +36,10 @@ ui::GestureStatus LocationIconView::OnGestureEvent(

return ui::GESTURE_STATUS_UNKNOWN;

}

+int LocationIconView::GetBuiltInHorizontalPadding() const {

+ return GetBuiltInHorizontalPaddingImpl();

void LocationIconView::ShowTooltip(bool show) {

if (show) {

SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON));