Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1051663002: Move HasSeekPenalty() out of base::SysInfo and base/. (Closed)

Created:
5 years, 8 months ago by Dan Beam
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@xp-vista
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move HasSeekPenalty() out of base::SysInfo and base/. It's only called from one place, so move it there: - chrome/browser/metrics/drive_metrics_provider.cc R=rvargas@chromium.org,asvitkine@chromium.org BUG=463209 Committed: https://crrev.com/005649e4ef576270314678ca7c2aab55e557ee35 Cr-Commit-Position: refs/heads/master@{#323526}

Patch Set 1 : merge #

Total comments: 2

Patch Set 2 : impl files #

Patch Set 3 : tests #

Total comments: 2

Patch Set 4 : rvargas@ nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -129 lines) Patch
M base/sys_info.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/sys_info_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/sys_info_chromeos.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M base/sys_info_freebsd.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/sys_info_ios.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M base/sys_info_linux.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/sys_info_mac.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M base/sys_info_openbsd.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/sys_info_unittest.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M base/sys_info_win.cc View 3 chunks +0 lines, -78 lines 0 comments Download
M chrome/browser/metrics/drive_metrics_provider.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/metrics/drive_metrics_provider.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
A chrome/browser/metrics/drive_metrics_provider_android.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/metrics/drive_metrics_provider_ios.mm View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/metrics/drive_metrics_provider_unittest.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/metrics/drive_metrics_provider_win.cc View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Dan Beam
currently depends on: https://codereview.chromium.org/1003303006/ this CL can be made independent if the other one lags.
5 years, 8 months ago (2015-04-01 01:43:22 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/1051663002/diff/20001/chrome/browser/metrics/drive_metrics_provider.cc File chrome/browser/metrics/drive_metrics_provider.cc (right): https://codereview.chromium.org/1051663002/diff/20001/chrome/browser/metrics/drive_metrics_provider.cc#newcode7 chrome/browser/metrics/drive_metrics_provider.cc:7: #if defined(OS_WIN) I still prefer separate files for the ...
5 years, 8 months ago (2015-04-01 14:24:21 UTC) #2
Dan Beam
https://codereview.chromium.org/1051663002/diff/20001/chrome/browser/metrics/drive_metrics_provider.cc File chrome/browser/metrics/drive_metrics_provider.cc (right): https://codereview.chromium.org/1051663002/diff/20001/chrome/browser/metrics/drive_metrics_provider.cc#newcode7 chrome/browser/metrics/drive_metrics_provider.cc:7: #if defined(OS_WIN) On 2015/04/01 14:24:21, Alexei Svitkine wrote: > ...
5 years, 8 months ago (2015-04-01 21:51:52 UTC) #5
rvargas (doing something else)
lgtm https://codereview.chromium.org/1051663002/diff/80001/chrome/browser/metrics/drive_metrics_provider_win.cc File chrome/browser/metrics/drive_metrics_provider_win.cc (right): https://codereview.chromium.org/1051663002/diff/80001/chrome/browser/metrics/drive_metrics_provider_win.cc#newcode51 chrome/browser/metrics/drive_metrics_provider_win.cc:51: struct IDENTIFY_DEVICE_DATA { nit: I think it's cleaner ...
5 years, 8 months ago (2015-04-01 23:26:23 UTC) #6
Dan Beam
https://codereview.chromium.org/1051663002/diff/80001/chrome/browser/metrics/drive_metrics_provider_win.cc File chrome/browser/metrics/drive_metrics_provider_win.cc (right): https://codereview.chromium.org/1051663002/diff/80001/chrome/browser/metrics/drive_metrics_provider_win.cc#newcode51 chrome/browser/metrics/drive_metrics_provider_win.cc:51: struct IDENTIFY_DEVICE_DATA { On 2015/04/01 23:26:23, rvargas (soon out ...
5 years, 8 months ago (2015-04-01 23:33:46 UTC) #7
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-02 14:50:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051663002/100001
5 years, 8 months ago (2015-04-02 17:08:26 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 8 months ago (2015-04-02 17:24:55 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:27:17 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/005649e4ef576270314678ca7c2aab55e557ee35
Cr-Commit-Position: refs/heads/master@{#323526}

Powered by Google App Engine
This is Rietveld 408576698