Added LoadIC stub for getters.

Added LoadIC stub for getters.

Removed some dead constants on the way.

Committed: https://code.google.com/p/v8/source/detail?r=11735

[Vyacheslav Egorov (Google), 2012-06-05 14:56:05]

http://codereview.chromium.org/10515008/diff/4001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/10515008/diff/4001/src/ia32/stub-cache-ia32.cc...
src/ia32/stub-cache-ia32.cc:2888: NullCallWrapper(), CALL_AS_FUNCTION);
I think it should be CALL_AS_METHOD because it's this.get() if this is global
object you don't want strict getter to that it's own receiver because it would
think that it was invoked without this.

[Michael Starzinger, 2012-06-08 07:58:33]

LGTM (with one comment and one nit).

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc
File src/stub-cache.cc (right):

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#n...
src/stub-cache.cc:178: ASSERT(getter->IsSpecFunction());
Shouldn't that be getter->IsJSFunction() here, or does it correctly handle
function proxies?

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#n...
src/stub-cache.cc:180: // Note: map holder = receiver, CheckType =
RECEIVER_MAP_CHECK;
I don't understand this comment. Can we either turn it into a full sentence or
drop it?

[Sven Panne, 2012-06-08 08:47:52]

Rebasing and landing...

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc
File src/stub-cache.cc (right):

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#n...
src/stub-cache.cc:178: ASSERT(getter->IsSpecFunction());
On 2012/06/08 07:58:33, Michael Starzinger wrote:
> Shouldn't that be getter->IsJSFunction() here, or does it correctly handle
> function proxies?

This was just a leftover of a previous weaker typing with Object instead of
JSFunction, so I'll just remove that line.

https://chromiumcodereview.appspot.com/10515008/diff/4002/src/stub-cache.cc#n...
src/stub-cache.cc:180: // Note: map holder = receiver, CheckType =
RECEIVER_MAP_CHECK;
On 2012/06/08 07:58:33, Michael Starzinger wrote:
> I don't understand this comment. Can we either turn it into a full sentence or
> drop it?

And this was just a leftover when trying to make sense of the CallIC stuff used
for this LoadIC => will remove that line.