Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: chrome/test/DEPS

Issue 10515007: Tighten up DEPS checking to enforce that embedders of content only include public test headers. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/DEPS ('k') | chrome_frame/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # The test directory can do whatever it wants in chrome. 2 # The test directory can do whatever it wants in chrome.
3 "+chrome", 3 "+chrome",
4 4
5 # Tests under chrome/ shouldn't need to access the internals of 5 # Tests under chrome/ shouldn't need to access the internals of content/ and
6 # content/ and as such are allowed only content/public and 6 # as such are allowed only content/public. If you find yourself wanting to
7 # content/test (which is the "public" directory for tests depending 7 # write such a test, or a test that depends primarily on content, think about
8 # on content/). If you find yourself wanting to write such a test, 8 # whether the test belongs under content/, or should be split up into a test
9 # or a test that depends primarily on content, think about whether
10 # the test belongs under content/, or should be split up into a test
11 # within content/ and a test within chrome/. 9 # within content/ and a test within chrome/.
12 "-content",
13 "+content/public", 10 "+content/public",
14 "+content/test",
15 11
16 # TODO(joi): Need to remove all of these and use only content/public 12 # TODO(joi): Need to remove all of these and use only content/public
17 # and content/test. http://crbug.com/98716 13 # and content/test. http://crbug.com/98716
tfarina 2012/06/04 15:52:15 nit: and content/public/test?
jam 2012/06/04 15:56:09 line 10 already has content/public
tfarina 2012/06/04 15:57:55 so just remove that part of the comment, since it
jam 2012/06/04 16:26:50 http://codereview.chromium.org/10521005
18 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW! 14 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW!
19 "+content/browser/net/url_request_mock_http_job.h",
20 "+content/browser/net/url_request_slow_http_job.h",
21 "+content/browser/trace_controller.h",
22 "+content/common/debug_flags.h", 15 "+content/common/debug_flags.h",
23 "+content/common/injection_test_dll.h", 16 "+content/common/injection_test_dll.h",
24 "+content/renderer/mock_content_renderer_client.h", 17 "+content/renderer/mock_content_renderer_client.h",
25 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST! 18 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!
26 19
27 "+grit", # For generated headers 20 "+grit", # For generated headers
28 "+media/audio", 21 "+media/audio",
29 "+sandbox/src", 22 "+sandbox/src",
30 "+sandbox/tests", 23 "+sandbox/tests",
31 "+webkit/glue", 24 "+webkit/glue",
32 "+webkit/plugins", 25 "+webkit/plugins",
33 ] 26 ]
OLDNEW
« no previous file with comments | « chrome/DEPS ('k') | chrome_frame/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698