Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 105143014: Add base:: to string16 in Source/testing/runner/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
blink-reviews, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add base:: to string16 in Source/testing/runner/. R=eseidel@chromium.org BUG=329295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/testing/runner/MockGrammarCheck.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/testing/runner/MockSpellCheck.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/testing/runner/MockSpellCheck.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/testing/runner/SpellCheckClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/testing/runner/WebTestProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
7 years ago (2013-12-19 06:08:09 UTC) #1
eseidel
Why? We really shouldn't be using base in Blink anyway...
7 years ago (2013-12-19 06:15:46 UTC) #2
eseidel
Is there a "using namespace base" which we should be removing here?
7 years ago (2013-12-19 06:16:12 UTC) #3
Dan Beam
On 2013/12/19 06:16:12, eseidel wrote: > Is there a "using namespace base" which we should ...
7 years ago (2013-12-19 06:31:36 UTC) #4
eseidel
lgtm OK. An alternate fix would be to just make these not be base::string16's at ...
7 years ago (2013-12-19 06:40:00 UTC) #5
Dan Beam
On 2013/12/19 06:40:00, eseidel wrote: > lgtm > > OK. An alternate fix would be ...
7 years ago (2013-12-20 05:22:53 UTC) #6
eseidel
Jochen is moving this to content, btw. I think you want to just wait for ...
7 years ago (2013-12-20 05:30:57 UTC) #7
jochen (gone - plz use gerrit)
On 2013/12/20 05:30:57, eseidel wrote: > Jochen is moving this to content, btw. I think ...
7 years ago (2013-12-20 14:58:06 UTC) #8
Dan Beam
7 years ago (2013-12-20 19:01:12 UTC) #9
On 2013/12/20 14:58:06, jochen_ooo wrote:
> On 2013/12/20 05:30:57, eseidel wrote:
> > Jochen is moving this to content, btw.  I think you want to just wait for
him
> to
> > be done.
> 
> the library is now in content/shell/renderer/test_runner

great, here's the CL to update it (closing this one):
https://codereview.chromium.org/113653003/

Powered by Google App Engine
This is Rietveld 408576698