Chromium Code Reviews Chromium Code Reviews
Issue 10513009:
Indicate focused state on text buttons with blue outline. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "webkit/glue/webthemeengine_impl_linux.h" | 5 #include "webkit/glue/webthemeengine_impl_linux.h" |
| 6 | 6 |
| 7 #include "skia/ext/platform_canvas.h" | 7 #include "skia/ext/platform_canvas.h" |
| 8 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h" | 8 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h" |
| 9 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebSize.h" | 9 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebSize.h" |
| 10 #include "ui/base/native_theme/native_theme.h" | 10 #include "ui/base/native_theme/native_theme.h" |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 97 extra_params->button.indeterminate; | 97 extra_params->button.indeterminate; |
| 98 break; | 98 break; |
| 99 case WebThemeEngine::PartRadio: | 99 case WebThemeEngine::PartRadio: |
| 100 native_theme_extra_params->button.checked = extra_params->button.checked; | 100 native_theme_extra_params->button.checked = extra_params->button.checked; |
| 101 break; | 101 break; |
| 102 case WebThemeEngine::PartButton: | 102 case WebThemeEngine::PartButton: |
| 103 native_theme_extra_params->button.is_default = | 103 native_theme_extra_params->button.is_default = |
| 104 extra_params->button.isDefault; | 104 extra_params->button.isDefault; |
| 105 native_theme_extra_params->button.has_border = | 105 native_theme_extra_params->button.has_border = |
| 106 extra_params->button.hasBorder; | 106 extra_params->button.hasBorder; |
| 107 // Native buttons have a different focus style. | |
| 108 native_theme_extra_params->button.is_focused = | |
| 109 false; | |
|
tony
2012/06/04 19:20:45
Nit: false on previous line.
flackr
2012/06/05 14:13:18
Done.
| |
| 107 native_theme_extra_params->button.background_color = | 110 native_theme_extra_params->button.background_color = |
| 108 extra_params->button.backgroundColor; | 111 extra_params->button.backgroundColor; |
| 109 break; | 112 break; |
| 110 case WebThemeEngine::PartTextField: | 113 case WebThemeEngine::PartTextField: |
| 111 native_theme_extra_params->text_field.is_text_area = | 114 native_theme_extra_params->text_field.is_text_area = |
| 112 extra_params->textField.isTextArea; | 115 extra_params->textField.isTextArea; |
| 113 native_theme_extra_params->text_field.is_listbox = | 116 native_theme_extra_params->text_field.is_listbox = |
| 114 extra_params->textField.isListbox; | 117 extra_params->textField.isListbox; |
| 115 native_theme_extra_params->text_field.background_color = | 118 native_theme_extra_params->text_field.background_color = |
| 116 extra_params->textField.backgroundColor; | 119 extra_params->textField.backgroundColor; |
| (...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 174 part, state, extra_params, &native_theme_extra_params); | 177 part, state, extra_params, &native_theme_extra_params); |
| 175 ui::NativeTheme::instance()->Paint( | 178 ui::NativeTheme::instance()->Paint( |
| 176 canvas, | 179 canvas, |
| 177 NativeThemePart(part), | 180 NativeThemePart(part), |
| 178 NativeThemeState(state), | 181 NativeThemeState(state), |
| 179 gfx::Rect(rect), | 182 gfx::Rect(rect), |
| 180 native_theme_extra_params); | 183 native_theme_extra_params); |
| 181 } | 184 } |
| 182 | 185 |
| 183 } // namespace webkit_glue | 186 } // namespace webkit_glue |
| OLD | NEW |
