Indicate focused state on text buttons with blue outline.

ui/base/native_theme/native_theme_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/native_theme/native_theme_base.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "grit/ui_resources_standard.h"
@@ skipping 469 matching lines @@
         rb.GetImageSkiaNamed(IDR_RADIO_ON) :
         rb.GetImageSkiaNamed(IDR_RADIO_OFF);
   }
 
   gfx::Rect bounds = rect.Center(gfx::Size(image->width(), image->height()));
   DrawBitmapInt(canvas, *image, 0, 0, image->width(), image->height(),
       bounds.x(), bounds.y(), bounds.width(), bounds.height());
 }
 
 void NativeThemeBase::PaintButton(SkCanvas* canvas,
                                    State state,

[tony, 2012/06/04 19:20:45]

Can you fix the indenting while you're here?

[flackr, 2012/06/05 14:13:18]

Done.

                                    const gfx::Rect& rect,
                                    const ButtonExtraParams& button) const {
   SkPaint paint;
   const int kRight = rect.right();
   const int kBottom = rect.bottom();
   SkRect skrect = SkRect::MakeLTRB(rect.x(), rect.y(), kRight, kBottom);
   SkColor base_color = button.background_color;
 
   color_utils::HSL base_hsl;
   color_utils::SkColorToHSL(base_color, &base_hsl);
@@ skipping 23 matching lines @@
       gradient_bounds, colors, NULL, 2, SkShader::kClamp_TileMode, NULL);
   paint.setStyle(SkPaint::kFill_Style);
   paint.setAntiAlias(true);
   paint.setShader(shader);
   shader->unref();
 
   canvas->drawRoundRect(skrect, SkIntToScalar(1), SkIntToScalar(1), paint);
   paint.setShader(NULL);
 
   if (button.has_border) {
-    const int kBorderAlpha = state == kHovered ? 0x80 : 0x55;
+    const int kBorderAlpha = button.is_focused ? 0xff :
+        state == kHovered ? 0x80 : 0x55;

[tony, 2012/06/04 19:20:45]

Nit: Nested ternary operators are hard to read.  Can we use an 'if' for the
is_focused check?  You could merge it with the if below.

[flackr, 2012/06/05 14:13:18]

Done.

+    if (button.is_focused)
+      paint.setColor(GetSystemColor(kColorId_FocusedBorderColor));
     paint.setStyle(SkPaint::kStroke_Style);
     paint.setStrokeWidth(SkIntToScalar(1));
-    paint.setARGB(kBorderAlpha, 0, 0, 0);
+    paint.setAlpha(kBorderAlpha);
     skrect.inset(SkFloatToScalar(.5f), SkFloatToScalar(.5f));
     canvas->drawRoundRect(skrect, SkIntToScalar(1), SkIntToScalar(1), paint);
   }
 }
 
 void NativeThemeBase::PaintTextField(SkCanvas* canvas,
                                      State state,
                                      const gfx::Rect& rect,
                                      const TextFieldExtraParams& text) const {
   // The following drawing code simulates the user-agent css border for
@@ skipping 358 matching lines @@
   SkScalar min_diff = Clamp((hsv1[1] + hsv2[1]) * 1.2f, 0.28f, 0.5f);
   SkScalar diff = Clamp(fabs(hsv1[2] - hsv2[2]) / 2, min_diff, 0.5f);
 
   if (hsv1[2] + hsv2[2] > 1.0)
     diff = -diff;
 
   return SaturateAndBrighten(hsv2, -0.2f, diff);
 }
 
 }  // namespace ui